feat(allowedsymbols): add per-package symbol lists for builtins/internal packages#121
Merged
AlexandreYang merged 5 commits intomainfrom Mar 18, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 1ccf688.
…nal packages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ls_interp_test.go Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mbols Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AlexandreYang
requested review from
astuyve,
julesmcrt,
matt-dz and
thieman
as code owners
AlexandreYang
changed the title
matt-dz
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internalPerPackageSymbolsmap insymbols_internal.go— a per-package allowlist for eachbuiltins/internal/<pkg>(loopctl, procinfo, winnet), mirroring the existingbuiltinPerCommandSymbolspatterninternalAllowedSymbolsas the global ceiling; each package's list must be a subset of itinternalPerPackageCheckConfig+TestInternalPerPackageSymbolsinsymbols_interp_test.gosymbols_interp_verification_test.go: clean pass, symbol not in common list, symbol not in per-package list, unused symbol flagged, missing package entryTest plan
go test ./allowedsymbols/passes🤖 Generated with Claude Code