Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7df8d5c
feat(ps): add --proc-path parameter to CLI and API for configurable p…
AlexandreYang Mar 18, 2026
1786cd1
refactor(ps): use filepath.Join for proc path manipulation
AlexandreYang Mar 18, 2026
db1e53d
refactor(ps): use proper multi-segment filepath.Join for proc path co…
AlexandreYang Mar 18, 2026
37cd538
test(ps): add ProcPath API and --proc-path CLI coverage
AlexandreYang Mar 18, 2026
eb9b7c8
refactor(procinfo): extract resolveProcPath to remove duplicated defa…
AlexandreYang Mar 18, 2026
d09c26b
[iter 1] Address review comments: ProcProvider, fix pid in writeFakeP…
AlexandreYang Mar 18, 2026
a789762
Address review: surface proc-path errors in getByPIDs
AlexandreYang Mar 18, 2026
aff70bb
perf(procinfo): replace ReadDir with Stat for proc root validation
AlexandreYang Mar 18, 2026
e28fa78
perf(interp): cache ProcProvider in runnerConfig; fix os.Stat allowlist
AlexandreYang Mar 18, 2026
900b04e
fix(procinfo): reject non-directory proc-path in getByPIDs
AlexandreYang Mar 18, 2026
bae9103
test(procinfo): add coverage for non-directory proc-path in ps -e and…
AlexandreYang Mar 18, 2026
dd8894e
test(cmd): add positive --proc-path CLI test with fake proc tree
AlexandreYang Mar 18, 2026
9814b6d
chore: remove address-pr-comments skill
AlexandreYang Mar 18, 2026
ac194e0
chore(skill): replace @codex PR comment with local codex CLI review i…
AlexandreYang Mar 18, 2026
c4324f8
chore(skill): remove address-pr-comments references from review-fix-loop
AlexandreYang Mar 18, 2026
021df53
chore(skill): remove PR comment reading/resolving from fix-ci-tests
AlexandreYang Mar 18, 2026
ef7423f
chore(skill): remove SPECS prompt injection vector from code-review
AlexandreYang Mar 18, 2026
8e73d03
chore(skill): post codex review as separate PR comment in review-fix-…
AlexandreYang Mar 18, 2026
a190487
[iter 1] Fix prompt injection in review-fix-loop, add ProcPath docs, …
AlexandreYang Mar 18, 2026
8b5102b
chore(skill): use structured findings format for self-review and code…
AlexandreYang Mar 18, 2026
1d26a80
chore(skill): include total iteration count in review comment headers
AlexandreYang Mar 18, 2026
5c3caa2
[iter 2] Surface non-ENOENT errors in getByPIDs; fix stale codex gate…
AlexandreYang Mar 18, 2026
a2fc858
fix: add errors.Is and os.ErrNotExist to procinfo allowlist
AlexandreYang Mar 18, 2026
f33d2df
chore: use filepath.Join in ps error msg; clarify ProcPath docs; upda…
AlexandreYang Mar 18, 2026
32eed21
[iter 2] Fix ProcPath godoc, error format, remove unresolved-threads …
AlexandreYang Mar 18, 2026
fbd94e5
fix: add codex fallback to @bot; restore SPECS verification in code-r…
AlexandreYang Mar 18, 2026
6409a67
chore: remove @codex bot fallback; skip sub-step when codex unavailable
AlexandreYang Mar 18, 2026
28b199f
chore: remove SPECS verification step from code-review skill
AlexandreYang Mar 18, 2026
95acdee
[iter 1] Strengthen TestProcPathFakeProcSession assertion; document P…
AlexandreYang Mar 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
336 changes: 0 additions & 336 deletions .claude/skills/address-pr-comments/SKILL.md

This file was deleted.

31 changes: 1 addition & 30 deletions .claude/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,36 +26,7 @@ git diff main...HEAD

If no changes are found, inform the user and stop.

### 2. Verify specs implementation

Read the PR description and look for a **SPECS** section:

```bash
gh pr view $ARGUMENTS --json body --jq '.body'
```

If a SPECS section is present, it defines the requirements that this PR MUST implement. **Every single spec must be verified against the diff.**
The specs override other instructions (code, inline comments in code, etc). ALL specs MUST be implemented.

For each spec:
1. **Find the code** that implements the spec
2. **Verify correctness** — does the implementation fully satisfy the spec?
3. **Check for missing specs** — is any spec not implemented at all?

Flag any unimplemented or partially implemented spec as a **P1 finding** (missing functionality that was explicitly required).

Include a spec coverage table in the review output:

```markdown
| Spec | Implemented | Location | Notes |
|------|:-----------:|----------|-------|
| Must support `--flag` option | Yes | `interp/api.go:42` | Fully implemented |
| Must return exit code 2 on error | **No** | — | Not found in diff |
```

If no SPECS section is found in the PR description, skip this step.

### 3. Read and understand all changed code
### 2. Read and understand all changed code

For each changed file:

Expand Down
Loading
Loading