fix(ip): fix CI failures in fuzz test and bash comparison tests#139
Merged
fix(ip): fix CI failures in fuzz test and bash comparison tests#139
Conversation
- FuzzIPSubcommand: allow exit code 255 (legitimate for ip route unknown subcommands, matching iproute2 behavior) and add regression corpus entry for "route 0" (ffdc891dc1bd740f) - route_unknown_subcmd, get_uppercase scenarios: add skip_assert_against_bash since ip is a rshell builtin not present in bash (bash returns 127) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thieman
requested review from
AlexandreYang,
astuyve,
julesmcrt and
matt-dz
as code owners
AlexandreYang
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two CI failures introduced alongside the
ip route show/getimplementation (#135):Fuzz (ip)failure:FuzzIPSubcommandincorrectly only allowed exit codes 0 and 1, butip route <unknown>legitimately exits with 255 (matching real iproute2 behavior). Updated the allowed exit codes and added regression corpus entryffdc891dc1bd740f(route 0).Test against Bash (Docker)failures:route_unknown_subcmdandget_uppercasescenarios were missingskip_assert_against_bash: true. Sinceipis a rshell builtin not present in bash, running these against bash returns exit 127 with "ip: command not found" instead of the expected rshell error.Test plan
Fuzz (ip)CI job passes (corpus entryffdc891dc1bd740fnow accepted with exit 255)Test against Bash (Docker)CI job passes (both ip route error scenarios skip bash assertion)🤖 Generated with Claude Code