Fix Windows test failures in ls scenarios#39
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Mar 10, 2026
Merged
Fix Windows test failures in ls scenarios#39gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
- basic_long.yaml, human_readable.yaml: Add stdout_contains_windows with -rw-rw-rw- since Windows doesn't support Unix group/other permission bits (chmod 0644 maps to -rw-rw-rw-) - outside_allowed_paths.yaml: Add stderr_windows matching the actual Windows error. On Windows /etc has no drive letter so it resolves as a relative path inside the sandbox temp dir, where os.Root produces "statat etc: no such file or directory". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matt-dz
force-pushed
the
matt-dz/fix-windows-test-failures
branch
from
ae8df60 to
611e63d
Compare
AlexandreYang
approved these changes
Mar 10, 2026
gh-worker-dd-mergequeue-cf854d
bot
deleted the
matt-dz/fix-windows-test-failures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lstest scenariosls -llong format tests: Windows mapschmod 0644to-rw-rw-rw-(no Unix group/other permission bits), so addstdout_contains_windowswith the correct Windows mode stringls /etcsandbox test:/etcdoesn't exist on Windows, producing "no such file or directory" instead of "permission denied", so addstderr_windowsoverrideTest plan
🤖 Generated with Claude Code