Skip to content

chore(ci): update the CI build image to not use an ancient version of Ubuntu#1045

Merged
tobz merged 3 commits intomainfrom
tobz/modernize-ci-build-image
Dec 8, 2025
Merged

chore(ci): update the CI build image to not use an ancient version of Ubuntu#1045
tobz merged 3 commits intomainfrom
tobz/modernize-ci-build-image

Conversation

@tobz
Copy link
Member

@tobz tobz commented Dec 8, 2025

Summary

As stated in the PR title.

We don't actually build ADP on the build CI image, but instead of Alpine so we can statically link against MUSL.. so there's no reason to use an ancient version of Ubuntu for glibc-related concerns. This will hopefully resolve the glibc issues we're seeing from switching to using cargo-binstall to pre-install all Cargo tooling, which won't line up with the older version of glibc present in the image.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Will build a new build CI image from this branch and verify that the issue is fixed before merging.

References

AGTMETRICS-393

@tobz tobz requested a review from a team as a code owner December 8, 2025 17:10
@tobz tobz added the type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. label Dec 8, 2025
@github-actions github-actions bot added the area/ci CI/CD, automated testing, etc. label Dec 8, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 8, 2025

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 602bb643-a0f4-4ec1-95be-44cc0566533c

Baseline: ed3c853
Comparison: 2dd4ec1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_metrics_adp memory utilization +1.43 [+1.21, +1.64] 1
otlp_ingest_logs_adp memory utilization +0.21 [-0.15, +0.58] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization +0.17 [+0.04, +0.30] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy ingress throughput +0.00 [-0.06, +0.07] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput +0.00 [-0.05, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.00 [-0.14, +0.13] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput -0.00 [-0.03, +0.02] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.28 [-0.33, -0.23] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.31 [-0.46, -0.16] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput -0.75 [-0.88, -0.62] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.80 [-0.98, -0.63] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
quality_gates_rss_dsd_heavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@tobz tobz merged commit 894995e into main Dec 8, 2025
52 checks passed
@tobz tobz deleted the tobz/modernize-ci-build-image branch December 8, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants