fix(correctness): properly enable DSD pipeline in ADP for DSD correctness tests#1072
Merged
dd-mergequeue[bot] merged 1 commit intomainfrom Dec 18, 2025
Conversation
github-actions
bot
added
the
area/test
Binary Size Analysis (Agent Data Plane)Target: 656d630 (baseline) vs aca10b9 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
| anon.6963da505859e1c5d18d13cd64b99327.1.llvm.11813514498431475664 | +130 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.1.llvm.9970088448890237782 | -129 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.4.llvm.11813514498431475664 | +115 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.4.llvm.9970088448890237782 | -114 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.3.llvm.11813514498431475664 | +109 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.3.llvm.9970088448890237782 | -108 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.0.llvm.11813514498431475664 | +97 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.0.llvm.9970088448890237782 | -96 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.2.llvm.11813514498431475664 | +95 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.2.llvm.9970088448890237782 | -94 B | 1 |
| [Unmapped] | +3 B | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +130 [NEW] +40 anon.6963da505859e1c5d18d13cd64b99327.1.llvm.11813514498431475664
[NEW] +115 [NEW] +25 anon.6963da505859e1c5d18d13cd64b99327.4.llvm.11813514498431475664
[NEW] +109 [NEW] +19 anon.6963da505859e1c5d18d13cd64b99327.3.llvm.11813514498431475664
[NEW] +97 [NEW] +7 anon.6963da505859e1c5d18d13cd64b99327.0.llvm.11813514498431475664
[NEW] +95 [NEW] +5 anon.6963da505859e1c5d18d13cd64b99327.2.llvm.11813514498431475664
+0.0% +3 [ = ] 0 [Unmapped]
[DEL] -94 [DEL] -5 anon.6963da505859e1c5d18d13cd64b99327.2.llvm.9970088448890237782
[DEL] -96 [DEL] -7 anon.6963da505859e1c5d18d13cd64b99327.0.llvm.9970088448890237782
[DEL] -108 [DEL] -19 anon.6963da505859e1c5d18d13cd64b99327.3.llvm.9970088448890237782
[DEL] -114 [DEL] -25 anon.6963da505859e1c5d18d13cd64b99327.4.llvm.9970088448890237782
[DEL] -129 [DEL] -40 anon.6963da505859e1c5d18d13cd64b99327.1.llvm.9970088448890237782
+0.0% +8 [ = ] 0 TOTAL
rayz
approved these changes
Dec 18, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
…ness tests (#1072) ## Summary This PR fixes an issue with setting the wrong environment variable to properly enable the DSD pipeline in ADP for the DSD-specific correctness tests. Simply put, we had an extra underscore in the variable name.. which meant ADP didn't think DSD should be enabled, and we also didn't disable DSD in the Core Agent. This led to the "comparison" actually being DSD running via Core Agent, hence how the tests still managed to pass. ## Change Type - [x] Bug fix - [ ] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? Ran the `dsd-plain` and `dsd-origin-detection` correctness tests, and checked the target logs on the comparison side to ensure we saw ADP start, stay started, and start listening on the DSD socket... while Core Agent avoided trying to also listen on the same sockets. ## References AGTMETRICS-393 Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com> c6d222d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with setting the wrong environment variable to properly enable the DSD pipeline in ADP for the DSD-specific correctness tests.
Simply put, we had an extra underscore in the variable name.. which meant ADP didn't think DSD should be enabled, and we also didn't disable DSD in the Core Agent. This led to the "comparison" actually being DSD running via Core Agent, hence how the tests still managed to pass.
Change Type
How did you test this PR?
Ran the
dsd-plainanddsd-origin-detectioncorrectness tests, and checked the target logs on the comparison side to ensure we saw ADP start, stay started, and start listening on the DSD socket... while Core Agent avoided trying to also listen on the same sockets.References
AGTMETRICS-393