Skip to content

chore(ci): update binary size analysis to work against stripped (release) artifacts#1128

Merged
tobz merged 3 commits intomainfrom
tobz/binary-size-analysis-split-debuginfo
Jan 28, 2026
Merged

chore(ci): update binary size analysis to work against stripped (release) artifacts#1128
tobz merged 3 commits intomainfrom
tobz/binary-size-analysis-split-debuginfo

Conversation

@tobz
Copy link
Member

@tobz tobz commented Jan 28, 2026

Summary

This PR updates our binary size analysis job to utilize stripped release binaries to more faithfully represent the actual size of the ADP binary when included in release artifacts.

Currently, we use the "full" debug binary -- release optimizations, but debug symbols included -- which is both massive and much larger than the release artifacts we generate.. but also just prone to changing by large amounts for even simple PRs, sometimes entirely due to the debug symbols included. This doesn't provide a realistically view of what a PR is going to do to the size of the release artifacts, which is ultimately what we care about.

This PR simply updates the analysis job/script to produce the binaries in full release mode (optimized-release, in terms of the Cargo profile used) and then splits the binary apart, leaving a stripped binary and its debug symbols. We use the debug symbols when invoking bloaty, but all analysis is done from the perspective of the stripped binaries

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Ensured that the job still ran cleanly on this PR, without error.

References

AGTMETRICS-393

@dd-octo-sts dd-octo-sts bot added area/ci CI/CD, automated testing, etc. area/test All things testing: unit/integration, correctness, SMP regression, etc. labels Jan 28, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2026

Binary Size Analysis (Agent Data Plane)

Target: c98fb8b (baseline) vs 75c5916 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 27.56 MiB
Comparison Size: 27.56 MiB
Size Change: +0 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

@tobz tobz added the type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. label Jan 28, 2026
@tobz tobz marked this pull request as ready for review January 28, 2026 03:00
@tobz tobz requested a review from a team as a code owner January 28, 2026 03:00
@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 56476193-2f75-4851-bbcb-2289032c2049

Baseline: c98fb8b
Comparison: 75c5916
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • otlp_ingest_logs_5mb_cpu
  • otlp_ingest_traces_5mb_memory
  • dsd_uds_1mb_3k_contexts_cpu
  • dsd_uds_512kb_3k_contexts_throughput

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +11.26 [+10.70, +11.82] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.12, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -3.69 [-8.68, +1.30] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +11.26 [+10.70, +11.82] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +3.37 [-27.12, +33.85] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +1.95 [-3.79, +7.69] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +1.03 [-4.86, +6.93] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization +0.80 [+0.55, +1.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization +0.70 [-54.30, +55.70] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization +0.45 [+0.33, +0.58] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.24 [+0.11, +0.38] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization +0.20 [+0.01, +0.40] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization +0.09 [-0.09, +0.27] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization +0.06 [-0.64, +0.76] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.02 [-0.02, +0.07] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.12, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput +0.01 [-0.12, +0.13] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.01 [-0.13, +0.12] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.01 [-0.06, +0.04] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.11 [-0.29, +0.08] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.14 [-0.32, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.18 [-0.35, -0.01] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.33 [-0.53, -0.14] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.34 [-1.82, +1.13] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.39 [-0.57, -0.20] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.46 [-0.51, -0.42] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput -0.81 [-0.93, -0.68] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -2.30 [-4.75, +0.15] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -3.56 [-54.84, +47.73] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -3.69 [-8.68, +1.30] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
quality_gates_rss_dsd_heavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
dsd_uds_1mb_3k_contexts_cpu baseline 8 Failed to shutdown when requested Debug Dashboard
dsd_uds_512kb_3k_contexts_throughput baseline 2 Failed to shutdown when requested Debug Dashboard
otlp_ingest_logs_5mb_cpu baseline 7 Failed to shutdown when requested Debug Dashboard
otlp_ingest_traces_5mb_memory baseline 0 Failed to shutdown when requested Debug Dashboard
otlp_ingest_traces_5mb_memory comparison 4 Failed to shutdown when requested Debug Dashboard

@tobz tobz merged commit 20314c2 into main Jan 28, 2026
56 checks passed
@tobz tobz deleted the tobz/binary-size-analysis-split-debuginfo branch January 28, 2026 15:02
dd-octo-sts bot pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. area/test All things testing: unit/integration, correctness, SMP regression, etc. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants