Skip to content

enhancement(otlp source): remove unecessary call to use_both_maps#1199

Merged
andrewqian2001datadog merged 1 commit intomainfrom
andrewq/avoid-intermediate-allocation
Feb 18, 2026
Merged

enhancement(otlp source): remove unecessary call to use_both_maps#1199
andrewqian2001datadog merged 1 commit intomainfrom
andrewq/avoid-intermediate-allocation

Conversation

@andrewqian2001datadog
Copy link
Contributor

@andrewqian2001datadog andrewqian2001datadog commented Feb 17, 2026

We don't need to call use_both_maps here as it performs unnecessary work (e.g. normalization) when we only need to check if the value is in the map.

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

…esence of the string here and use both maps does unecessary work (normalization, returning MetaString instead of bool)
@dd-octo-sts dd-octo-sts bot added the area/components Sources, transforms, and destinations. label Feb 17, 2026
@andrewqian2001datadog andrewqian2001datadog changed the title remove unecessary call to use_both_maps, we just need to check the pr… enhancement(otlp source): remove unecessary call to use_both_maps Feb 17, 2026
@andrewqian2001datadog andrewqian2001datadog marked this pull request as ready for review February 17, 2026 20:13
@andrewqian2001datadog andrewqian2001datadog requested a review from a team as a code owner February 17, 2026 20:13
@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Binary Size Analysis (Agent Data Plane)

Target: fb3531d (baseline) vs e81925a (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 26.87 MiB
Comparison Size: 26.88 MiB
Size Change: +4.00 KiB (+0.01%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
[Unmapped] +3.57 KiB 1
saluki_components::common::otlp +540 B 1
unicode_segmentation -96 B 1
tokio +6 B 1
std -4 B 1
[sections] -2 B 2

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +73% +3.57Ki  [ = ]       0    [Unmapped]
  +2.1%    +540  +2.1%    +540    saluki_components::common::otlp::traces::transform::otel_to_dd_span_minimal::h6897fffd65fcbd0e
  +0.0%     +12  +0.0%     +12    [section .gcc_except_table]
  +0.6%      +6  +0.7%      +6    tokio::sync::notify::NotifiedProject::drop_notified::hddb245abb5729052
  -0.6%      -4  -0.7%      -4    std::io::error::Error::new::h20308ff3f5782c19
  -0.0%     -14  -0.0%     -14    [section .text]
  -0.5%     -96  -0.5%     -96    unicode_segmentation::grapheme::GraphemeCursor::grapheme_category::h5f61abd61f4ab1b3
  +0.0% +4.00Ki  +0.0%    +444    TOTAL

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: c31971ab-a127-480c-96f4-10b6ff3f1a71

Baseline: fb3531d
Comparison: e81925a
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • otlp_ingest_traces_5mb_cpu
  • otlp_ingest_logs_5mb_throughput
  • dsd_uds_1mb_3k_contexts_throughput

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +1.18 [+0.74, +1.63] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.28 [-4.98, +5.54] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.00 [-0.13, +0.13] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_512kb_3k_contexts_cpu % cpu utilization +3.17 [-51.74, +58.09] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization +1.18 [+0.74, +1.63] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +0.75 [+0.62, +0.88] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization +0.50 [+0.44, +0.57] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.31 [+0.18, +0.43] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.28 [-4.98, +5.54] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization +0.02 [-0.17, +0.20] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.01 [-0.03, +0.04] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput +0.00 [-0.02, +0.03] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput +0.00 [-0.05, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization +0.00 [-0.18, +0.18] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.00 [-0.13, +0.13] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.00 [-0.15, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.01 [-0.14, +0.12] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.02 [-0.21, +0.18] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.04 [-0.32, +0.24] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.05 [-1.35, +1.24] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.07 [-0.20, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.26 [-0.46, -0.07] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.42 [-0.61, -0.23] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.45 [-0.61, -0.29] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.51 [-0.70, -0.31] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization -0.78 [-6.76, +5.20] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -0.91 [-3.01, +1.18] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -1.60 [-1.87, -1.33] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization -3.09 [-9.46, +3.28] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization -6.94 [-35.72, +21.84] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -7.62 [-57.14, +41.90] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
quality_gates_rss_dsd_heavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
dsd_uds_1mb_3k_contexts_throughput baseline 7 Failed to shutdown when requested Debug Dashboard
otlp_ingest_logs_5mb_throughput comparison 2 Failed to shutdown when requested Debug Dashboard
otlp_ingest_traces_5mb_cpu comparison 8 Failed to shutdown when requested Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
otlp_ingest_traces_5mb_cpu comparison 11 Failed to shutdown when requested Debug Dashboard

@andrewqian2001datadog andrewqian2001datadog changed the title enhancement(otlp source): remove unecessary call to use_both_maps [AGNTLOG-554] enhancement(otlp source): remove unecessary call to use_both_maps Feb 17, 2026
@andrewqian2001datadog andrewqian2001datadog changed the title [AGNTLOG-554] enhancement(otlp source): remove unecessary call to use_both_maps enhancement(otlp source): remove unecessary call to use_both_maps Feb 17, 2026
@andrewqian2001datadog
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 18, 2026

View all feedbacks in Devflow UI.

2026-02-18 18:22:41 UTC ℹ️ Start processing command /merge


2026-02-18 18:22:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 22m (p90).


2026-02-18 18:26:45 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 0243116:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@andrewqian2001datadog andrewqian2001datadog merged commit 2503613 into main Feb 18, 2026
61 of 64 checks passed
dd-octo-sts bot pushed a commit that referenced this pull request Feb 18, 2026
)

We don't need to call `use_both_maps` here as it performs unnecessary
work (e.g. normalization) when we only need to check if the value is in
the map.

## Summary
<!-- Please provide a brief summary about what this PR does.
This should help the reviewers give feedback faster and with higher
quality. -->

## Change Type
- [ ] Bug fix
- [ ] New feature
- [ ] Non-functional (chore, refactoring, docs)
- [x] Performance

## How did you test this PR?
<!-- Please how you tested these changes here -->

## References

<!-- Please list any issues closed by this PR. -->

<!--
- Closes: <issue link>
-->

<!-- Any other issues or PRs relevant to this PR? Feel free to list them
here. --> 2503613
@tobz tobz deleted the andrewq/avoid-intermediate-allocation branch February 25, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/components Sources, transforms, and destinations. mergequeue-status: rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants