Skip to content

fix(env): use BTreeMap for stable check ID hash computation#1213

Merged
tobz merged 1 commit into
mainfrom
fabbing/stable_check_id
Feb 24, 2026
Merged

fix(env): use BTreeMap for stable check ID hash computation#1213
tobz merged 1 commit into
mainfrom
fabbing/stable_check_id

Conversation

@fabbing
Copy link
Copy Markdown
Contributor

@fabbing fabbing commented Feb 24, 2026

Summary

Use BTreeMap instead of HashMap for check's Data and RawData config. This allows to compute stable hash, allowing a stable check ID.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Trusted the compiler.
... and ran the test suite.

References

@fabbing fabbing requested a review from a team as a code owner February 24, 2026 12:23
@dd-octo-sts dd-octo-sts Bot added the area/config Configuration. label Feb 24, 2026
@fabbing fabbing force-pushed the fabbing/stable_check_id branch from e88fdd2 to 0e90d74 Compare February 24, 2026 12:30
@fabbing fabbing changed the title fix: use BTreeMap for stable check ID hash computation fix(env): use BTreeMap for stable check ID hash computation Feb 24, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 24, 2026

Binary Size Analysis (Agent Data Plane)

Target: f058439 (baseline) vs 0e90d74 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 27.39 MiB
Comparison Size: 27.39 MiB
Size Change: +0 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 24, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 5903eac0-f295-4fa4-a284-68d0a9c6e1aa

Baseline: f058439
Comparison: 0e90d74
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • otlp_ingest_traces_5mb_throughput
  • dsd_uds_1mb_3k_contexts_memory
  • dsd_uds_512kb_3k_contexts_memory

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +0.73 [+0.10, +1.35] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.03 [-0.16, +0.09] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -1.86 [-7.13, +3.41] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +11.33 [-19.47, +42.13] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +1.71 [+1.58, +1.84] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization +0.84 [+0.72, +0.97] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +0.75 [-5.40, +6.90] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization +0.73 [+0.10, +1.35] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization +0.64 [+0.45, +0.84] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization +0.27 [+0.08, +0.47] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization +0.13 [-0.03, +0.29] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization +0.07 [-0.11, +0.25] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput +0.03 [-0.09, +0.15] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.01 [-0.05, +0.07] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput +0.00 [-0.15, +0.16] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput +0.00 [-0.02, +0.03] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.03 [-0.16, +0.09] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.19 [-0.37, +0.00] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.22 [-0.42, -0.03] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization -0.33 [-0.51, -0.15] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.38 [-0.42, -0.35] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.48 [-0.72, -0.23] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.58 [-1.94, +0.78] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization -0.83 [-0.96, -0.70] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -1.30 [-3.58, +0.98] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -1.43 [-1.65, -1.20] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -1.86 [-7.13, +3.41] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization -2.07 [-7.99, +3.84] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -2.16 [-55.83, +51.50] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -4.63 [-54.74, +45.48] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
quality_gates_rss_dsd_heavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
dsd_uds_1mb_3k_contexts_memory comparison 7 Failed to shutdown when requested Debug Dashboard
dsd_uds_512kb_3k_contexts_memory comparison 3 Failed to shutdown when requested Debug Dashboard
otlp_ingest_traces_5mb_throughput baseline 2 Failed to shutdown when requested Debug Dashboard

@tobz tobz merged commit 9d97edb into main Feb 24, 2026
57 of 59 checks passed
@tobz tobz deleted the fabbing/stable_check_id branch February 24, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants