Skip to content

fix(components): count bytes received for OTLP gRPC exports#1249

Merged
tobz merged 1 commit intoDataDog:mainfrom
gyubin02:fix/grpc-bytes-received-metric
Mar 19, 2026
Merged

fix(components): count bytes received for OTLP gRPC exports#1249
tobz merged 1 commit intoDataDog:mainfrom
gyubin02:fix/grpc-bytes-received-metric

Conversation

@gyubin02
Copy link
Contributor

Summary

Fixes missing component_bytes_received_total accounting for OTLP gRPC requests.

The HTTP path was already incrementing bytes_received, but the shared gRPC OTLP path was not. This change updates
the gRPC metrics, logs, and traces export() handlers to increment the counter using the serialized protobuf payload
size.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

  • Added regression tests for OTLP gRPC metrics/logs/traces exports to verify that component_bytes_received_total is
    incremented.
  • Ran:
    • cargo test -p saluki-components updates_bytes_received

References

@gyubin02 gyubin02 requested a review from a team as a code owner March 16, 2026 12:25
@dd-octo-sts dd-octo-sts bot added the area/components Sources, transforms, and destinations. label Mar 16, 2026
@tobz tobz added the type/bug Bug fixes. label Mar 16, 2026
@tobz tobz changed the title fix(otlp): count bytes received for gRPC exports fix(otlp source): count bytes received for gRPC exports Mar 16, 2026
@tobz
Copy link
Member

tobz commented Mar 16, 2026

Awesome. Thanks for your contribution. :)

@gyubin02 gyubin02 changed the title fix(otlp source): count bytes received for gRPC exports fix(components): count bytes received for OTLP gRPC exports Mar 17, 2026
@gyubin02
Copy link
Contributor Author

Thanks for the approval. The required dd-gitlab checks are still stuck in "Expected" on GitHub, so the PR can't merge yet. Could you please trigger or rerun the GitLab CI for this PR?

@tobz
Copy link
Member

tobz commented Mar 19, 2026

Thanks for the approval. The required dd-gitlab checks are still stuck in "Expected" on GitHub, so the PR can't merge yet. Could you please trigger or rerun the GitLab CI for this PR?

Yeah, that's weird. I'll try giving those a kick to get things moving again.

@tobz
Copy link
Member

tobz commented Mar 19, 2026

@gyubin02 Alright, got CI to run and things look good.

Last step is just to sign our CLA. We don't have the CLA bot set up yet (yay, you're our first external contribution! 🎉) so I'm pasting it here manually.

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


@gyubin02
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tobz tobz merged commit 61f98b2 into DataDog:main Mar 19, 2026
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/components Sources, transforms, and destinations. type/bug Bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTLP source doesn't properly emit component_bytes_received_total.

3 participants