Skip to content

enhancement(dev): add a devcontainer config for Workspaces#1269

Merged
tobz merged 1 commit into
mainfrom
tobz/devcontainer
Mar 27, 2026
Merged

enhancement(dev): add a devcontainer config for Workspaces#1269
tobz merged 1 commit into
mainfrom
tobz/devcontainer

Conversation

@tobz
Copy link
Copy Markdown
Member

@tobz tobz commented Mar 26, 2026

Summary

This PR adds a devcontainer configuration suitable for working on Saluki/ADP.

It's placed specifically for use with Datadog-internal tooling, but could be used with standard Devcontainers tooling without issue.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Ensured that we could both initialize the devcontainer (devcontainer up ...) and build ADP within it (devcontainer exec ... make build-adp) without issue.

References

AGTMETRICS-400

@tobz tobz requested a review from a team as a code owner March 26, 2026 23:49
@tobz tobz added the type/enhancement An enhancement in functionality or support. label Mar 26, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 26, 2026

Binary Size Analysis (Agent Data Plane)

Target: b0ed855 (baseline) vs 65eb88d (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 26.18 MiB
Comparison Size: 26.18 MiB
Size Change: +0 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 27, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: fc154171-e2cc-4ae2-ae82-bfa8b23d010b

Baseline: b0ed855
Comparison: 65eb88d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_cpu % cpu utilization +0.92 [-4.09, +5.93] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.03 [-0.15, +0.10] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -6.60 [-6.94, -6.26] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_1mb_3k_contexts_cpu % cpu utilization +1.92 [-52.81, +56.64] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +1.89 [-28.76, +32.54] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +1.82 [-0.29, +3.94] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization +1.70 [-0.80, +4.20] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +1.11 [-7.44, +9.67] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization +1.02 [+0.84, +1.19] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.92 [-4.09, +5.93] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +0.64 [+0.50, +0.77] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization +0.31 [+0.14, +0.49] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization +0.30 [+0.11, +0.49] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +0.17 [-5.44, +5.78] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization +0.11 [-0.14, +0.35] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization +0.10 [+0.08, +0.13] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization +0.06 [-0.07, +0.20] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization +0.04 [-0.14, +0.21] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput +0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput +0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput +0.00 [-0.05, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput +0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput -0.00 [-0.04, +0.04] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput -0.00 [-0.02, +0.02] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.00 [-0.15, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.01 [-0.14, +0.12] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.02 [-0.26, +0.23] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.03 [-0.15, +0.10] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization -0.08 [-0.21, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.12 [-0.30, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.12 [-0.29, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.33 [-0.51, -0.15] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.44 [-0.64, -0.24] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.50 [-1.84, +0.85] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization -0.59 [-0.93, -0.25] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -2.01 [-4.14, +0.13] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -6.60 [-6.94, -6.26] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -8.52 [-63.00, +45.95] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 112.98MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 33.41MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 53.01MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 166.32MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 21.01MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Copy Markdown
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want to run as many things as I can locally, but this is great! 😎

@tobz tobz merged commit fc62b57 into main Mar 27, 2026
60 checks passed
@tobz tobz deleted the tobz/devcontainer branch April 10, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement An enhancement in functionality or support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants