chore(dev): use 'minimal' profile for rustup to slim down Rust installs#1271
Merged
Conversation
tobz
added
the
type/chore
Binary Size Analysis (Agent Data Plane)Target: 5a8776b (baseline) vs b179844 (comparison) diff
|
| Module | File Size | Symbols |
|---|
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[ = ] 0 [ = ] 0 TOTAL
Regression Detector (Agent Data Plane)This comment was omitted because it was over 65,536 characters.Please check the Gitlab Job logs to see its output. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As stated in the PR title.
This avoids things like install
rust-docswhich are never needed in CI, and shouldn't really be needed locally. If someone wants them, they can install them manually.This should make our CI images smaller and faster to download, and in turn make cold image builds just a little bit faster.
Change Type
How did you test this PR?
Built ADP,
millstone, anddatadog-intakeimages locally and ensured they still built correctly. Manually triggered a run of the build CI image job and ensured it ran to completion and that it got much slimmer.References
AGTMETRICS-400