Skip to content

chore(io): replace hyper-hickory with slimmer internal version#1553

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
tobz/drop-hyper-hickory
May 1, 2026
Merged

chore(io): replace hyper-hickory with slimmer internal version#1553
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
tobz/drop-hyper-hickory

Conversation

@tobz
Copy link
Copy Markdown
Member

@tobz tobz commented May 1, 2026

Summary

PR title says it all, really.

Given the RustSec advisories related to hickory-resolver that we can't resolve until hyper-hickory updates, I opted to replace our usage of hyper-hickory with a slimmed down version. We use a fraction of what hyper-hickory exposes, so this just tightens up our supply chain a wee bit by depending on one less crate while also allowing us to bring in the necessary transitive dependency bumps.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Existing tests.

References

N/A

@tobz tobz requested a review from a team as a code owner May 1, 2026 16:41
@tobz tobz added the type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. label May 1, 2026
@dd-octo-sts dd-octo-sts Bot added the area/io General I/O and networking. label May 1, 2026
@jszwedko
Copy link
Copy Markdown
Collaborator

jszwedko commented May 1, 2026

Seems like we are still dependent on a vulnerable version of hickory-proto:

147 │ hickory-proto 0.26.1 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0118
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0118

Not sure if you expected that to be fixed by this though or just other vulnerabilities.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 1, 2026

Binary Size Analysis (Agent Data Plane)

Target: d74438c (baseline) vs 0b9f30e (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 36.71 MiB
Comparison Size: 36.83 MiB
Size Change: +129.27 KiB (+0.34%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
hickory_net +129.38 KiB 128
hickory_proto -68.77 KiB 622
futures_util +28.64 KiB 158
anon.77aae97c5e2d3612c16fa5ce6626e3e8.1029.llvm.1262250578423513277 +28.07 KiB 1
anon.c5caf31de3a9a4ede1631b810e36d1d0.1029.llvm.9667255209399341798 -28.07 KiB 1
core -21.82 KiB 16242
alloc +19.77 KiB 2831
saluki_io::net::dns +13.73 KiB 2
hashbrown +11.54 KiB 1140
hickory_resolver -8.98 KiB 169
crossbeam_channel -8.71 KiB 236
hyper_hickory -8.48 KiB 3
chacha20 +8.29 KiB 8
hyper_util +8.01 KiB 473
prefix_trie +7.88 KiB 4
anyhow +7.74 KiB 1599
saluki_io::net::client -7.31 KiB 68
hyper_http_proxy -6.83 KiB 34
moka -6.59 KiB 212
[sections] +6.45 KiB 9

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +1.77Mi  [NEW] +1.77Mi    _<chrono_tz::prebuilt::timezones::Tz as chrono_tz::timezone_impl::TimeSpans>::timespans::hf7ab39f4921fbc99
  [NEW]  +158Ki  [NEW]  +158Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h6fb9b29a45ab5fb5
  +0.6%  +129Ki  +0.6%  +112Ki    [53239 Others]
  [NEW] +64.6Ki  [NEW] +64.4Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::hfc1d986edfe35750
  [NEW] +64.0Ki  [NEW] +63.9Ki    agent_data_plane::run_inner::_{{closure}}::h35dc3e043af65280
  [NEW] +62.8Ki  [NEW] +62.7Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::hb83390fd1e126bb2
  [NEW] +58.2Ki  [NEW] +58.0Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h6d5e5b07739a9da2
  [NEW] +57.5Ki  [NEW] +57.3Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::h6324ce3e0ca3b167
  [NEW] +48.4Ki  [NEW] +48.2Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::hf7c183e2bbc22a9d
  [NEW] +46.4Ki  [NEW] +46.2Ki    saluki_components::common::otlp::traces::translator::OtlpTracesTranslator::translate_spans::hc215b49d0af723c4
  [NEW] +43.5Ki  [NEW] +43.4Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::h69978318fe976280
  [DEL] -43.5Ki  [DEL] -43.4Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::h41bbdfb398ffc402
  [DEL] -46.4Ki  [DEL] -46.2Ki    saluki_components::common::otlp::traces::translator::OtlpTracesTranslator::translate_spans::h7f3ab65c8fec78cd
  [DEL] -48.3Ki  [DEL] -48.1Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h93562a18a6bfd85c
  [DEL] -57.5Ki  [DEL] -57.3Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::h965c6db136660c6c
  [DEL] -58.2Ki  [DEL] -58.0Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h92652bb731b7a6ce
  [DEL] -62.8Ki  [DEL] -62.6Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::h07a486be4c2edd20
  [DEL] -64.0Ki  [DEL] -63.9Ki    agent_data_plane::run_inner::_{{closure}}::h20110c513004fd69
  [DEL] -64.6Ki  [DEL] -64.4Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::h1f7106bedd18ac02
  [DEL]  -158Ki  [DEL]  -158Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::hb3b19bf2b3d78330
  [DEL] -1.77Mi  [DEL] -1.77Mi    _<chrono_tz::prebuilt::timezones::Tz as chrono_tz::timezone_impl::TimeSpans>::timespans::h9901e6331ebf2719
  +0.3%  +129Ki  +0.4%  +112Ki    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 1, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 094ba1e2-3115-4d2e-a5c0-8bdd7340d75d

Baseline: d74438c
Comparison: 0b9f30e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_cpu % cpu utilization +0.56 [-3.44, +4.56] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.01 [-0.13, +0.11] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -10.59 [-10.98, -10.19] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_1mb_3k_contexts_cpu % cpu utilization +3.23 [-50.71, +57.17] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +1.55 [-28.84, +31.95] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization +0.85 [-1.22, +2.93] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.56 [-3.44, +4.56] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization +0.54 [-0.89, +1.96] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization +0.51 [+0.35, +0.67] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization +0.31 [+0.15, +0.47] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.17 [+0.04, +0.29] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization +0.09 [-0.04, +0.21] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +0.03 [-5.92, +5.99] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput +0.02 [-0.17, +0.21] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.05, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.01 [-0.17, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.01 [-0.13, +0.11] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput -0.02 [-0.06, +0.02] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput -0.04 [-0.11, +0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization -0.07 [-0.32, +0.17] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput -0.10 [-0.18, -0.03] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.16 [-0.31, -0.01] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.21 [-0.28, -0.14] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.22 [-0.39, -0.06] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.27 [-0.41, -0.12] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.31 [-0.47, -0.16] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.32 [-0.49, -0.15] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization -0.51 [-0.65, -0.37] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.54 [-0.68, -0.40] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.63 [-0.68, -0.58] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -0.84 [-1.04, -0.63] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization -1.12 [-3.19, +0.95] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput -1.35 [-1.46, -1.23] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization -2.10 [-7.67, +3.47] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization -3.01 [-4.92, -1.10] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -6.36 [-60.92, +48.21] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -10.59 [-10.98, -10.19] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 120.41MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 40.20MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 60.70MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 175.57MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 27.51MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 0b3f591 into main May 1, 2026
71 checks passed
dd-octo-sts Bot pushed a commit that referenced this pull request May 1, 2026
## Summary

PR title says it all, really.

Given the RustSec advisories related to `hickory-resolver` that we can't resolve until `hyper-hickory` updates, I opted to replace our usage of `hyper-hickory` with a slimmed down version. We use a fraction of what `hyper-hickory` exposes, so this just tightens up our supply chain a wee bit by depending on one less crate while also allowing us to bring in the necessary transitive dependency bumps.

## Change Type
- [ ] Bug fix
- [ ] New feature
- [x] Non-functional (chore, refactoring, docs)
- [ ] Performance

## How did you test this PR?

Existing tests.

## References

N/A

Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com> 0b3f591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/io General I/O and networking. mergequeue-status: done type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants