Skip to content

chore(env): ignore gpu entity ID type#1568

Merged
tobz merged 1 commit into
mainfrom
tobz/ignore-gpu-entity-id-type
May 4, 2026
Merged

chore(env): ignore gpu entity ID type#1568
tobz merged 1 commit into
mainfrom
tobz/ignore-gpu-entity-id-type

Conversation

@tobz
Copy link
Copy Markdown
Member

@tobz tobz commented May 4, 2026

Summary

As stated in the PR title.

Just helps us silence the Unhandled entity ID prefix: gpu://[varying] warning logs.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Existing tests.

References

DADP-51

@tobz tobz added the type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. label May 4, 2026
@tobz tobz requested a review from a team as a code owner May 4, 2026 12:21
@dd-octo-sts dd-octo-sts Bot added the area/config Configuration. label May 4, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 4, 2026

Binary Size Analysis (Agent Data Plane)

Target: ba41a54 (baseline) vs 464000f (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 36.73 MiB
Comparison Size: 36.73 MiB
Size Change: +24 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
hashbrown -2.39 KiB 4
anon.49195b7910753fb616da5a2a5c932f7b.56.llvm.14819124142970953544 +1.69 KiB 1
anon.c06d8d76ac45cd2c0276b36521babfa8.200.llvm.13518369433171653420 -1.69 KiB 1
axum +1.58 KiB 2
prost +1.42 KiB 10
anon.d39d42e54fea0e48527806a82155bc7d.314.llvm.17891254150457159696 +1.22 KiB 1
anon.a8dd78cf18237faaafd1daac2a69e26e.207.llvm.12168795120858866766 -1.22 KiB 1
[Unmapped] +1.18 KiB 1
anon.7e2bdba11d2ad4a7fee2208bdd3d10e9.787.llvm.15035878147524304148 +1.14 KiB 1
anon.de4621689c3835e72e5282464b1e1cc1.618.llvm.17220783872678718975 -1.14 KiB 1
tower -988 B 2
prost_types +837 B 2
core -803 B 211
anon.de4621689c3835e72e5282464b1e1cc1.169.llvm.17705344661383600538 +652 B 1
anon.de4621689c3835e72e5282464b1e1cc1.169.llvm.17220783872678718975 -652 B 1
anon.17c0eb63022353d2d414ab73f05ba36e.23.llvm.8132063429521549938 +644 B 1
anon.4e0ddd07d841d17c659f9f4d94fc566c.1.llvm.12840771278609007254 -643 B 1
anon.7e2bdba11d2ad4a7fee2208bdd3d10e9.276.llvm.1550668850714090042 -643 B 1
anon.e32b82b077c25a20d35fb0a2170b4e05.1.llvm.15757848718261292345 +642 B 1
anon.7e2bdba11d2ad4a7fee2208bdd3d10e9.272.llvm.15035878147524304148 +641 B 1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +1.69Ki  [NEW]     +97    anon.49195b7910753fb616da5a2a5c932f7b.56.llvm.14819124142970953544
  [NEW] +1.50Ki  [NEW] +1.42Ki    prost::encoding::hash_map::merge::hf32c736f0086ef8b
  [NEW] +1.35Ki  [NEW]     +33    core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<datadog_protos::agent_include::datadog::model::v1::ConfigStreamRequest>,tokio_stream::stream_ext::map::Map<tokio_stream::once::Once<datadog_protos::agent_include::datadog::model::v1::ConfigStreamRequest>,core::result::Result<datadog_protos::agent_include::datadog::model::v1::ConfigStreamRequest,tonic::status::Status>::Ok>>,tonic::status::Status::map_error<tonic::status::Status>>>::h0dfa3a30666f764b
  [NEW] +1.30Ki  [NEW]    +129    core::ptr::drop_in_place<std::sync::poison::PoisonError<std::sync::poison::rwlock::RwLockWriteGuard<quick_cache::shard::CacheShard<u64,saluki_env::workload::origin::ResolvedOrigin,saluki_common::cache::weight::WrappedWeighter<saluki_common::cache::weight::ItemCountWeighter>,foldhash::quality::RandomState,saluki_common::cache::expiry::ExpiryCapableLifecycle<u64>,alloc::sync::Arc<quick_cache::sync_placeholder::Placeholder<saluki_env::workload::origin::ResolvedOrigin>>>>>>::hd4ac53f26c6257ef
  [NEW] +1.26Ki  [NEW]     +47    _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::hd6f39326d9790701
  [NEW] +1.22Ki  [NEW]     +74    anon.d39d42e54fea0e48527806a82155bc7d.314.llvm.17891254150457159696
   +30% +1.18Ki  [ = ]       0    [Unmapped]
  [NEW] +1.14Ki  [NEW]     +80    anon.7e2bdba11d2ad4a7fee2208bdd3d10e9.787.llvm.15035878147524304148
  +165%    +941  +100%    +393    core::ptr::drop_in_place<containerd_protos::containerd_include::containerd::services::containers::v1::ListContainersRequest>::h08efb811782f7a7b
  [NEW]    +808  [NEW]    +615    _<axum::handler::service::HandlerService<H,T,S> as tower_service::Service<http::request::Request<B>>>::call::h6278fb14832e6c12
  [NEW]    +808  [NEW]    +615    _<axum::handler::service::HandlerService<H,T,S> as tower_service::Service<http::request::Request<B>>>::call::h8c4974bd2fa5858f
 -40.3%    -944 -25.0%    -393    core::ptr::drop_in_place<containerd_protos::containerd_include::containerd::services::events::v1::SubscribeRequest>::hc76feec410e9f5dd
  [DEL] -1.04Ki  [DEL]    -966    hashbrown::map::HashMap<K,V,S,A>::insert::hb5907739341f16f4
  [DEL] -1.13Ki  [DEL] -1.03Ki    hashbrown::map::HashMap<K,V,S,A>::insert::h53a8b31406f006b9
  [DEL] -1.14Ki  [DEL]     -80    anon.de4621689c3835e72e5282464b1e1cc1.618.llvm.17220783872678718975
  [DEL] -1.22Ki  [DEL]     -74    anon.a8dd78cf18237faaafd1daac2a69e26e.207.llvm.12168795120858866766
  [DEL] -1.26Ki  [DEL]     -47    _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::h2a63fd2023170aba
  [DEL] -1.30Ki  [DEL]    -129    core::ptr::drop_in_place<std::sync::poison::PoisonError<std::sync::poison::rwlock::RwLockWriteGuard<quick_cache::shard::CacheShard<u32,saluki_env::workload::entity::EntityId,saluki_common::cache::weight::WrappedWeighter<saluki_common::cache::weight::ItemCountWeighter>,foldhash::quality::RandomState,saluki_common::cache::expiry::ExpiryCapableLifecycle<u32>,alloc::sync::Arc<quick_cache::sync_placeholder::Placeholder<saluki_env::workload::entity::EntityId>>>>>>::h244f7525398b6ce3
  [DEL] -1.35Ki  [DEL]     -33    core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<containerd_protos::containerd_include::containerd::services::tasks::v1::ListPidsRequest>,tokio_stream::stream_ext::map::Map<tokio_stream::once::Once<containerd_protos::containerd_include::containerd::services::tasks::v1::ListPidsRequest>,core::result::Result<containerd_protos::containerd_include::containerd::services::tasks::v1::ListPidsRequest,tonic::status::Status>::Ok>>,tonic::status::Status::map_error<tonic::status::Status>>>::h1c8d0473445a2d1b
  [DEL] -1.69Ki  [DEL]     -97    anon.c06d8d76ac45cd2c0276b36521babfa8.200.llvm.13518369433171653420
  -0.1% -2.06Ki  -0.1% -1.82Ki    [1397 Others]
  +0.0%     +24  -0.0% -1.18Ki    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 4, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 3907c7e9-748f-43c5-802e-4446a0178333

Baseline: ba41a54
Comparison: 464000f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +3.28 [+2.85, +3.71] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.72 [-4.10, +5.53] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.04 [-0.16, +0.09] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +3.28 [+2.85, +3.71] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +2.87 [-27.41, +33.16] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +1.46 [-0.57, +3.50] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.72 [-4.10, +5.53] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization +0.39 [-52.96, +53.73] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +0.23 [-5.58, +6.05] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization +0.17 [-1.30, +1.64] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization +0.17 [+0.00, +0.33] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization +0.16 [-1.89, +2.22] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.08 [-0.05, +0.21] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.05, +0.05] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.01 [-0.19, +0.17] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput -0.01 [-0.05, +0.03] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.02 [-0.21, +0.17] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.04 [-0.16, +0.09] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization -0.05 [-0.29, +0.19] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.05 [-0.17, +0.07] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.05 [-0.20, +0.10] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.05 [-0.22, +0.11] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput -0.10 [-0.18, -0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization -0.11 [-0.27, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.11 [-0.28, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization -0.12 [-0.26, +0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.13 [-0.20, -0.06] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.25 [-0.30, -0.20] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.29 [-0.45, -0.13] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.58 [-0.73, -0.43] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -0.62 [-0.83, -0.40] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput -0.62 [-0.70, -0.54] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.71 [-0.86, -0.56] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput -0.75 [-0.87, -0.63] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization -1.30 [-3.65, +1.04] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization -1.32 [-7.19, +4.54] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -5.86 [-59.77, +48.05] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 120.57MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 40.29MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 60.46MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 175.36MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 27.40MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@tobz tobz merged commit d113f77 into main May 4, 2026
70 checks passed
@tobz tobz deleted the tobz/ignore-gpu-entity-id-type branch May 4, 2026 13:58
dd-octo-sts Bot pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants