chore(dogstatsd): do not run dogstatsd twice in oltp tests#1570
Conversation
Binary Size Analysis (Agent Data Plane)Target: 08ee4b4 (baseline) vs ba37cb2 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.1776047624409219327 |
-129 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.60285251824362632 |
+127 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.1776047624409219327 |
-114 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.60285251824362632 |
+112 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.1776047624409219327 |
-108 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.60285251824362632 |
+106 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.1776047624409219327 |
-96 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.60285251824362632 |
+94 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.1776047624409219327 |
-94 B | 1 |
anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.60285251824362632 |
+92 B | 1 |
[Unmapped] |
+2 B | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +127 [NEW] +40 anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.60285251824362632
[NEW] +112 [NEW] +25 anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.60285251824362632
[NEW] +106 [NEW] +19 anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.60285251824362632
[NEW] +94 [NEW] +7 anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.60285251824362632
[NEW] +92 [NEW] +5 anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.60285251824362632
+0.0% +2 [ = ] 0 [Unmapped]
[DEL] -94 [DEL] -5 anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.1776047624409219327
[DEL] -96 [DEL] -7 anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.1776047624409219327
[DEL] -108 [DEL] -19 anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.1776047624409219327
[DEL] -114 [DEL] -25 anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.1776047624409219327
[DEL] -129 [DEL] -40 anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.1776047624409219327
-0.0% -8 [ = ] 0 TOTAL
Regression Detector (Agent Data Plane)Regression Detector ResultsRun ID: 55f53ea2-29e8-44d1-a9ec-1261ac153a3c Baseline: 08ee4b4 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | otlp_ingest_logs_5mb_memory | memory utilization | +15.65 | [+15.25, +16.04] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_logs_5mb_cpu | % cpu utilization | +1.51 | [-3.15, +6.17] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_logs_5mb_throughput | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | (metrics) (profiles) (logs) |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | otlp_ingest_logs_5mb_memory | memory utilization | +15.65 | [+15.25, +16.04] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_1mb_3k_contexts_cpu | % cpu utilization | +4.45 | [-49.64, +58.54] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_transform_5mb_cpu | % cpu utilization | +1.75 | [-0.10, +3.59] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_logs_5mb_cpu | % cpu utilization | +1.51 | [-3.15, +6.17] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_metrics_5mb_memory | memory utilization | +1.10 | [+0.89, +1.31] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_500mb_3k_contexts_throughput | ingress throughput | +1.10 | [+0.99, +1.21] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_100mb_3k_contexts_cpu | % cpu utilization | +0.99 | [-4.60, +6.58] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_10mb_3k_contexts_cpu | % cpu utilization | +0.45 | [-29.26, +30.16] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_transform_5mb_memory | memory utilization | +0.23 | [+0.07, +0.39] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_transform_5mb_throughput | ingress throughput | +0.22 | [+0.14, +0.29] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_filtering_5mb_memory | memory utilization | +0.17 | [-0.07, +0.41] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_1mb_3k_contexts_memory | memory utilization | +0.16 | [+0.02, +0.30] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_100mb_3k_contexts_memory | memory utilization | +0.12 | [-0.03, +0.27] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_10mb_3k_contexts_memory | memory utilization | +0.11 | [-0.04, +0.27] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_metrics_5mb_throughput | ingress throughput | +0.02 | [-0.16, +0.19] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_filtering_5mb_throughput | ingress throughput | +0.01 | [-0.07, +0.08] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_logs_5mb_throughput | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_100mb_3k_contexts_throughput | ingress throughput | +0.00 | [-0.03, +0.03] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_1mb_3k_contexts_throughput | ingress throughput | -0.00 | [-0.06, +0.06] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_512kb_3k_contexts_throughput | ingress throughput | -0.00 | [-0.06, +0.05] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_10mb_3k_contexts_throughput | ingress throughput | -0.01 | [-0.19, +0.18] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_idle | memory utilization | -0.01 | [-0.05, +0.03] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_512kb_3k_contexts_memory | memory utilization | -0.05 | [-0.20, +0.09] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_ultraheavy | memory utilization | -0.10 | [-0.24, +0.04] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_heavy | memory utilization | -0.11 | [-0.24, +0.01] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_5mb_throughput | ingress throughput | -0.13 | [-0.21, -0.06] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_medium | memory utilization | -0.20 | [-0.37, -0.03] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_low | memory utilization | -0.34 | [-0.49, -0.18] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_500mb_3k_contexts_memory | memory utilization | -0.39 | [-0.54, -0.24] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_5mb_memory | memory utilization | -0.39 | [-0.55, -0.23] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_500mb_3k_contexts_cpu | % cpu utilization | -0.57 | [-1.93, +0.79] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_metrics_5mb_cpu | % cpu utilization | -0.69 | [-6.41, +5.03] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_ottl_filtering_5mb_cpu | % cpu utilization | -1.34 | [-3.51, +0.83] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_traces_5mb_cpu | % cpu utilization | -1.73 | [-3.82, +0.37] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_512kb_3k_contexts_cpu | % cpu utilization | -3.51 | [-58.09, +51.07] | 1 | (metrics) (profiles) (logs) |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gates_rss_dsd_heavy | memory_usage | 10/10 | 121.96MiB ≤ 140MiB | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_low | memory_usage | 10/10 | 39.94MiB ≤ 50MiB | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_medium | memory_usage | 10/10 | 61.95MiB ≤ 75MiB | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_ultraheavy | memory_usage | 10/10 | 177.61MiB ≤ 200MiB | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_idle | memory_usage | 10/10 | 27.55MiB ≤ 40MiB | (metrics) (profiles) (logs) |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
Apparently this is the wrong approach. Closing. |
8558c9f to
a00fa53
Compare
OTLP correctness tests never disabled DogStatsD, which was fine when it defaulted to off. After the default flipped to on, ADP races the Core Agent for UDP port 8125 and crash-loops if it loses. Disable DogStatsD explicitly in OTLP test configs.
a00fa53 to
bc12b3e
Compare
## Summary OTLP correctness tests never disabled DogStatsD, which was fine when it defaulted to off. After the default flipped to on, ADP races the Core Agent for UDP port 8125 and crash-loops if it loses. Disable DogStatsD explicitly in OTLP test configs. ## Change Type - [x] Bug fix - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? The tests were reliably failing for me before this change and passed after the change. ## References #1567 5a8bfdb
Summary
OTLP correctness tests never disabled DogStatsD, which was fine when it defaulted to off. After the default flipped to on, ADP races the Core Agent for UDP port 8125 and crash-loops if it loses. Disable DogStatsD explicitly in OTLP test configs.
Change Type
How did you test this PR?
The tests were reliably failing for me before this change and passed after the change.
References
#1567