chore(ci): add semantic pr scopes for test work#1571
Conversation
tobz
left a comment
tobz
left a comment
There was a problem hiding this comment.
We should actually add these to FIXED_SCOPES in tooling/update-pr-title-scopes.sh, and then run make update-pr-title-scopes to actually regenerate them.
CI will check if there's a mismatch after running make update-pr-title-scopes and fail otherwise.
Ah, sorry I didn't see that. Will do. Ok with the scopes? |
I've had a few PRs where a scope that matches what I was doing didn't seem to exist. These were all while working on testing, so I have added a few scopes that seem to reasonably cover testing scopes.
|
Oh, it had actually drifted. Those unexpected changes came from |
tobz
left a comment
tobz
left a comment
There was a problem hiding this comment.
Yeah, the fixed scopes being added here are fine by me. 👍🏻
## Summary I've had a few PRs where a scope that matches what I was doing didn't seem to exist. These were all while working on testing, so I have added a few scopes that seem to reasonably cover testing scopes. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? N/A ## References N/A 8b9dadb
3 participants
Summary
I've had a few PRs where a scope that matches what I was doing didn't seem to exist. These were all while working on testing, so I have added a few scopes that seem to reasonably cover testing scopes.
Change Type
How did you test this PR?
N/A
References
N/A