enhancement(agent-data-plane): Move DogStatsD prefix filter into ADP and share filterlist helpers

[aqian01]

Summary

Follow up PR for this comment

Moves the DogStatsD prefix filter into ADP and adds shared filterlist helpers. The prefix and post-aggregate filters now use the same blocklist matching and filterlist fallback logic instead of duplicating it.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

Existing tests still verify behaviour.

References

[pr-commenter]

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: eb770cab-add6-4654-84de-23245d72dc39

Baseline: 6842079
Comparison: 582ed05
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+2.58	[-2.28, +7.44]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_memory	memory utilization	+1.71	[+1.33, +2.10]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	+0.01	[-0.11, +0.13]	1	(metrics) (profiles) (logs)

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+2.58	[-2.28, +7.44]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_memory	memory utilization	+2.53	[+2.35, +2.71]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_throughput	ingress throughput	+2.19	[+2.08, +2.31]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_memory	memory utilization	+1.71	[+1.33, +2.10]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_cpu	% cpu utilization	+0.94	[-54.83, +56.72]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_cpu	% cpu utilization	+0.68	[-1.30, +2.66]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_memory	memory utilization	+0.52	[+0.36, +0.67]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_cpu	% cpu utilization	+0.51	[-29.17, +30.19]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_low	memory utilization	+0.51	[+0.34, +0.67]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_cpu	% cpu utilization	+0.45	[-1.92, +2.81]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_throughput	ingress throughput	+0.39	[+0.31, +0.47]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_heavy	memory utilization	+0.38	[+0.26, +0.51]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_ultraheavy	memory utilization	+0.29	[+0.15, +0.42]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_memory	memory utilization	+0.17	[+0.01, +0.32]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_memory	memory utilization	+0.11	[-0.03, +0.26]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_memory	memory utilization	+0.10	[-0.06, +0.26]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_throughput	ingress throughput	+0.08	[+0.01, +0.16]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_cpu	% cpu utilization	+0.06	[-1.31, +1.44]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_throughput	ingress throughput	+0.01	[-0.15, +0.17]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	+0.01	[-0.11, +0.13]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_throughput	ingress throughput	+0.00	[-0.17, +0.18]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_throughput	ingress throughput	+0.00	[-0.05, +0.05]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_throughput	ingress throughput	-0.00	[-0.06, +0.05]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_throughput	ingress throughput	-0.02	[-0.09, +0.05]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_throughput	ingress throughput	-0.02	[-0.07, +0.02]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_memory	memory utilization	-0.05	[-0.28, +0.19]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_memory	memory utilization	-0.06	[-0.21, +0.09]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_memory	memory utilization	-0.06	[-0.20, +0.08]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_medium	memory utilization	-0.13	[-0.29, +0.04]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_idle	memory utilization	-0.13	[-0.17, -0.09]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_cpu	% cpu utilization	-0.23	[-2.31, +1.86]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_memory	memory utilization	-0.41	[-0.55, -0.26]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_cpu	% cpu utilization	-1.19	[-7.05, +4.67]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_cpu	% cpu utilization	-3.10	[-55.35, +49.16]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_cpu	% cpu utilization	-4.20	[-9.14, +0.74]	1	(metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gates_rss_dsd_heavy	memory_usage	10/10	124.18MiB ≤ 140MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_low	memory_usage	10/10	40.84MiB ≤ 50MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_medium	memory_usage	10/10	62.69MiB ≤ 75MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	172.36MiB ≤ 200MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_idle	memory_usage	10/10	28.25MiB ≤ 40MiB	(metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Target: 6842079 (baseline) vs 582ed05 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 37.32 MiB
Comparison Size: 37.36 MiB
Size Change: +39.32 KiB (+0.10%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module	File Size	Symbols
saluki_components::transforms::dogstatsd_prefix_filter	-29.37 KiB	31
agent_data_plane::components::dogstatsd_prefix_filter	+28.82 KiB	30
core	+17.01 KiB	1788
saluki_components::sources::otlp	-16.20 KiB	11
hyper_util	-13.86 KiB	20
hyper	+13.83 KiB	108
tokio_rustls	-13.12 KiB	18
std	-12.87 KiB	74
serde_core	-11.44 KiB	67
otlp_protos::otlp_include::opentelemetry	+9.54 KiB	75
quick_cache	+8.90 KiB	20
rustls	+8.65 KiB	10
axum	+7.96 KiB	60
saluki_common::cache::Cache<K,V,W,H>	-7.38 KiB	8
h2	+7.37 KiB	106
http_serde_ext	+7.34 KiB	9
tonic	-7.33 KiB	113
crossbeam_channel	+7.24 KiB	28
alloc	-6.37 KiB	261
saluki_config::dynamic::watcher	-5.78 KiB	3

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7% +59.8Ki  +0.8% +56.8Ki    [7975 Others]
  [NEW] +33.1Ki  [NEW] +33.0Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::h92f302a3bb230913
 +13e3% +16.5Ki +34e3% +16.5Ki    core::ops::function::FnOnce::call_once::h27ba218c27ff657a
  [NEW] +8.62Ki  [NEW] +8.51Ki    rustls::conn::ConnectionCore<Data>::process_new_packets::hebecac8aad6fcffc
  [NEW] +7.87Ki  [NEW] +7.65Ki    _<agent_data_plane::components::dogstatsd_prefix_filter::DogStatsDPrefixFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::hcf87c542688d471a
  [NEW] +7.49Ki  [NEW] +7.25Ki    _<agent_data_plane::components::dogstatsd_post_aggregate_filter::DogStatsDPostAggregateFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::he60c4342d09d644f
   +68% +7.08Ki   +70% +7.08Ki    _<agent_data_plane::components::tag_filterlist::TagFilterlist as saluki_core::components::transforms::Transform>::run::_{{closure}}::h1a12fb16a6fbba22
  [NEW] +7.06Ki  [NEW] +6.95Ki    hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch::h253f13ffb64a469f
  [NEW] +7.00Ki  [NEW] +6.88Ki    hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch::h6e1db7db72095e01
  [DEL] -6.56Ki  [DEL] -6.41Ki    _<core::marker::PhantomData<T> as serde_core::de::DeserializeSeed>::deserialize::hb3cdddb849b93036
  [DEL] -6.84Ki  [DEL] -6.62Ki    _<saluki_components::transforms::dogstatsd_prefix_filter::DogStatsDPrefixFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::h2066eaa08ac614b8
 -76.4% -7.11Ki -77.7% -7.11Ki    _<hyper_util::server::conn::auto::Connection<I,S,E> as core::future::future::Future>::poll::h0b1f0a73f946a8be
 -75.1% -7.98Ki -76.3% -7.98Ki    _<hyper_util::server::conn::auto::Connection<I,S,E> as core::future::future::Future>::poll::h4dc09f88c41557dc
  [DEL] -8.06Ki  [DEL] -7.90Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::h4d570d2d226f8269
 -89.6% -9.22Ki -90.8% -9.22Ki    _<h2::client::Connection<T,B> as core::future::future::Future>::poll::h9d42d1c116602d15
 -89.6% -9.43Ki -90.3% -9.35Ki    tokio_rustls::common::Stream<IO,C>::read_io::hfe0b19d219b6c8b6
 -90.2% -9.81Ki -91.3% -9.81Ki    _<h2::client::Connection<T,B> as core::future::future::Future>::poll::h4d601a7be188c777
  [DEL] -10.9Ki  [DEL] -10.7Ki    _<figment::value::magic::Tagged<T> as figment::value::magic::Magic>::deserialize_from::h226575457f44ed69
  [DEL] -11.0Ki  [DEL] -10.8Ki    _<agent_data_plane::components::dogstatsd_post_aggregate_filter::DogStatsDPostAggregateFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::hc0298e479cd9b727
  [DEL] -11.6Ki  [DEL] -11.4Ki    _<figment::value::magic::RelativePathBuf as figment::value::magic::Magic>::deserialize_from::h705ff6707566d258
  [DEL] -16.7Ki  [DEL] -16.5Ki    saluki_components::sources::otlp::metrics::runtime_metrics::RUNTIME_METRICS_MAPPINGS::_{{closure}}::h9c408191b1722278
  +0.1% +39.3Ki  +0.1% +36.7Ki    TOTAL