Skip to content

feat(dogstatsd): log oversized UDS stream frames#1600

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
lt/1342
May 6, 2026
Merged

feat(dogstatsd): log oversized UDS stream frames#1600
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
lt/1342

Conversation

@lucastemb
Copy link
Copy Markdown
Contributor

Summary

Adds a corresponding log line when a frame exceeds the expected maximum size.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Tested manually by running ADP in standalone mode with dogstatsd_stream_socket enabled, dogstatsd_buffer_size: 64, and dogstatsd_stream_log_too_big: true, then sending an oversized UDS stream frame with a 65-byte length prefix. ADP emitted the expected warning: DogStatsD stream frame exceeded the configured buffer size.

Also verified that setting dogstatsd_stream_log_too_big: false still rejects the oversized frame without emitting the warning.

Screenshot 2026-05-06 at 2 38 15 PM

References

@lucastemb lucastemb requested a review from a team as a code owner May 6, 2026 18:40
@dd-octo-sts dd-octo-sts Bot added area/components Sources, transforms, and destinations. source/dogstatsd DogStatsD source. area/docs Reference documentation. labels May 6, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 6, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 3a58b3ad-29e9-44e2-85dc-fbc1dec67cf7

Baseline: 6842079
Comparison: dd4bacc
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_cpu % cpu utilization +0.87 [-4.04, +5.77] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.11, +0.14] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -9.84 [-10.16, -9.53] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_traces_5mb_cpu % cpu utilization +2.14 [-0.02, +4.29] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +0.94 [+0.83, +1.06] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +0.91 [-1.10, +2.91] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.87 [-4.04, +5.77] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +0.79 [-4.89, +6.47] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization +0.39 [+0.24, +0.54] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.35 [+0.21, +0.49] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization +0.24 [+0.10, +0.38] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization +0.10 [-0.10, +0.30] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization +0.09 [-2.20, +2.39] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.11, +0.14] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.00 [-0.04, +0.04] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.01 [-0.06, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.01 [-0.16, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.02 [-0.21, +0.17] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.04 [-0.19, +0.11] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.07 [-0.23, +0.10] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.07 [-0.22, +0.07] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.08 [-0.24, +0.09] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.09 [-0.24, +0.06] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.10 [-0.18, -0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput -0.12 [-0.22, -0.02] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.18 [-0.34, -0.03] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput -0.19 [-0.27, -0.12] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization -0.21 [-0.44, +0.03] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.35 [-0.48, -0.23] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization -0.35 [-0.51, -0.19] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization -0.51 [-29.90, +28.88] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.53 [-1.94, +0.88] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.65 [-0.70, -0.61] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization -1.19 [-6.93, +4.55] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -8.71 [-61.36, +43.93] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization -9.84 [-10.16, -9.53] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -10.55 [-61.41, +40.30] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 124.05MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 40.69MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 60.94MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 178.52MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 27.78MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit a2ace57 into main May 6, 2026
67 checks passed
dd-octo-sts Bot pushed a commit that referenced this pull request May 6, 2026
## Summary
<!-- Please provide a brief summary about what this PR does.
This should help the reviewers give feedback faster and with higher quality. -->

Adds a corresponding log line when a frame exceeds the expected maximum size.

## Change Type
- [ ] Bug fix
- [x] New feature
- [ ] Non-functional (chore, refactoring, docs)
- [ ] Performance

## How did you test this PR?
<!-- Please how you tested these changes here -->

Tested manually by running ADP in standalone mode with `dogstatsd_stream_socket` enabled, `dogstatsd_buffer_size: 64`, and `dogstatsd_stream_log_too_big: true`, then sending an oversized UDS stream frame with a 65-byte length prefix. ADP emitted the expected warning: `DogStatsD stream frame exceeded the configured buffer size.`

  Also verified that setting `dogstatsd_stream_log_too_big: false` still rejects the oversized frame without emitting the warning.

<img width="1916" height="494" alt="Screenshot 2026-05-06 at 2 38 15 PM" src="https://github.com/user-attachments/assets/3f489a14-c5ce-4cae-99a5-368db72e7908" />

## References

<!-- Please list any issues closed by this PR. -->

<!--
- Closes: <issue link>
-->
- Closes: #1342

<!-- Any other issues or PRs relevant to this PR? Feel free to list them here. -->

Co-authored-by: lucas.tembras <lucas.tembras@datadoghq.com> a2ace57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/components Sources, transforms, and destinations. area/docs Reference documentation. mergequeue-status: done source/dogstatsd DogStatsD source.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log oversized UDS stream frames when dogstatsd_stream_log_too_big is set.

2 participants