Skip to content

chore(ci): disallow std::str::from_utf8 in favor of simdutf8#1615

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
thieman/disallow-std-from-utf8
May 11, 2026
Merged

chore(ci): disallow std::str::from_utf8 in favor of simdutf8#1615
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
thieman/disallow-std-from-utf8

Conversation

@thieman
Copy link
Copy Markdown
Contributor

@thieman thieman commented May 8, 2026

Summary

  • Adds a disallowed_methods Clippy rule in clippy.toml to enforce simdutf8::basic::from_utf8 over std::str::from_utf8 / core::str::from_utf8
  • Fixes the three existing call sites in process-memory and saluki-components (adds simdutf8 as a dependency to both crates)
  • Suppresses the lint at module level in stele/traces/stats.rs where the serde_with::DeserializeFromStr proc macro generates code that calls core::str::from_utf8 internally

Test plan

  • Pre-commit Clippy check passes (make check-all)
  • Any future use of std::str::from_utf8 will be a hard Clippy error

🤖 Generated with Claude Code

@thieman thieman requested a review from a team as a code owner May 8, 2026 20:26
@dd-octo-sts dd-octo-sts Bot added area/components Sources, transforms, and destinations. area/memory Memory bounds and memory management. transform/trace-obfuscation Trace Obfuscation synchronous transform. labels May 8, 2026
@thieman thieman changed the title ci(lint): disallow std::str::from_utf8 in favor of simdutf8 chore(lint): disallow std::str::from_utf8 in favor of simdutf8 May 8, 2026
@thieman thieman changed the title chore(lint): disallow std::str::from_utf8 in favor of simdutf8 chore(ci): disallow std::str::from_utf8 in favor of simdutf8 May 8, 2026
@thieman thieman marked this pull request as draft May 8, 2026 20:29
@thieman thieman marked this pull request as ready for review May 8, 2026 20:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 8, 2026

Binary Size Analysis (Agent Data Plane)

Target: 3cd84b8 (baseline) vs 8806ae1 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 37.52 MiB
Comparison Size: 37.52 MiB
Size Change: +1.13 KiB (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
anon.05044b273a7e4a8d31259722e79fc658.47.llvm.15667338004991869279 +3.46 KiB 1
anon.69e428a9b82147ac32380934c88376aa.256.llvm.6445384337222873251 -3.46 KiB 1
anon.c1c7ec8ec680e4785be08d066b5ec12c.2.llvm.657345546224115985 +3.06 KiB 1
anon.37efd500d662fac30494dfcb6655a0cd.162.llvm.15594617127947676363 -3.06 KiB 1
async_compression +2.65 KiB 29
anon.40340ab29c26454e228b882d4ecb70d4.0.llvm.14605026808982526804 +2.54 KiB 1
anon.63341532a4d49b8c3cc9467823eb1ff5.274.llvm.3829532915946058138 -2.54 KiB 1
std +2.32 KiB 627
anon.7cd6d703f2f53452dab0cda0b6b49a63.387.llvm.7998522543445554412 +2.02 KiB 1
anon.cba4d4cf840e67ce7cdeecce4ae8d468.34.llvm.8160406689773534850 -2.02 KiB 1
anon.c32b882dc9a901bea9cd0e91763dadc6.0.llvm.17022429934584739220 -1.93 KiB 1
anon.41b0b8befc3118c3a2b0f17ec06872eb.9.llvm.17862187855904175761 +1.93 KiB 1
tracing_appender -1.85 KiB 2
core -1.77 KiB 14492
anon.132d920c7bdb38cd3787ad47c663b1cf.168.llvm.13853470600906238408 +1.69 KiB 1
anon.fd7b529fe56f46398ecdea2e5e277011.5.llvm.6425510092197803827 -1.69 KiB 1
anon.20c6d10ffdfe634d87c9e7aba437e92d.60.llvm.13980903373425538139 +1.66 KiB 1
anon.c48ff0e6482e9ea96d0a6d75f812ff16.47.llvm.4059303811155592612 -1.66 KiB 1
anon.a83a71c4b83a79edeca7b83a8dcbce9f.419.llvm.15374769797868559346 -1.50 KiB 1
anon.2314fe97fd74670b92f784008184dc91.127.llvm.9355374571703845791 +1.50 KiB 1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]  +147Ki  [NEW]  +147Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::haf0764c1bab35be1
  [NEW] +68.9Ki  [NEW] +68.8Ki    agent_data_plane::run_inner::_{{closure}}::h431462389819e7d8
  [NEW] +66.9Ki  [NEW] +66.8Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::h3a2ac749f3279e68
  [NEW] +65.4Ki  [NEW] +65.2Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::h42f0965f10a48f70
  [NEW] +57.8Ki  [NEW] +57.7Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::hfd2563136634e6a4
  [NEW] +57.7Ki  [NEW] +57.6Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h526a161f5f0ddc93
  [NEW] +56.9Ki  [NEW] +56.7Ki    agent_data_plane::internal::env::workload::RemoteAgentWorkloadProvider::from_configuration::_{{closure}}::h2eb61ab2f373fb14
  [NEW] +50.8Ki  [NEW] +50.6Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::had9c978a8964fad7
  [NEW] +41.2Ki  [NEW] +41.0Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::hd7933f67a582e518
  [NEW] +40.0Ki  [NEW] +39.8Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h4858182d5ea79c95
  +0.0%    +959  +0.0% +3.34Ki    [46813 Others]
  [DEL] -40.1Ki  [DEL] -39.9Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::hde4459a01e3f9227
  [DEL] -41.0Ki  [DEL] -40.8Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h09537e0f77e66173
  [DEL] -50.8Ki  [DEL] -50.6Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h43075509d7ce59ea
  [DEL] -56.9Ki  [DEL] -56.7Ki    agent_data_plane::internal::env::workload::RemoteAgentWorkloadProvider::from_configuration::_{{closure}}::hb791ff1a07efb07e
  [DEL] -57.7Ki  [DEL] -57.6Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h3e314072cc66659a
  [DEL] -57.8Ki  [DEL] -57.7Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::h51e2d17685e5879d
  [DEL] -65.4Ki  [DEL] -65.2Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::h8438abea594e7f4b
  [DEL] -66.9Ki  [DEL] -66.8Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::hb2ea473da8501e18
  [DEL] -68.9Ki  [DEL] -68.8Ki    agent_data_plane::run_inner::_{{closure}}::hc6c22ce20d0c6ae6
  [DEL]  -147Ki  [DEL]  -147Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h93dd78edc7b9f901
  +0.0% +1.13Ki  +0.0% +3.53Ki    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 8, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: d5fa10f3-ae5d-4ec4-91c1-b66c8f56760b

Baseline: 3cd84b8
Comparison: 8806ae1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +1.22 [+0.75, +1.69] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.66 [-4.16, +5.49] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.02 [-0.14, +0.10] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization +1.65 [-0.73, +4.03] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_memory memory utilization +1.22 [+0.75, +1.69] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization +1.18 [-0.93, +3.29] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +1.16 [-4.75, +7.07] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +0.84 [-1.29, +2.97] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +0.82 [-5.33, +6.97] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization +0.66 [-4.16, +5.49] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization +0.37 [+0.22, +0.52] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization +0.33 [+0.12, +0.53] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +0.28 [-31.55, +32.11] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization +0.20 [+0.05, +0.35] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization +0.20 [+0.04, +0.36] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput +0.17 [+0.06, +0.28] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput +0.09 [+0.02, +0.16] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization +0.02 [-0.13, +0.18] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization +0.02 [-0.11, +0.16] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput +0.01 [-0.06, +0.08] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.01 [-0.02, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization +0.01 [-0.03, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization -0.01 [-0.17, +0.15] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput -0.01 [-0.18, +0.16] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.01 [-0.20, +0.18] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput -0.02 [-0.14, +0.10] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput -0.02 [-0.09, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.15 [-0.28, -0.02] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization -0.19 [-0.33, -0.04] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization -0.26 [-0.40, -0.11] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization -0.32 [-0.49, -0.16] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization -0.33 [-0.57, -0.09] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.41 [-1.77, +0.96] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.47 [-0.64, -0.30] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization -4.98 [-62.46, +52.50] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -5.55 [-60.32, +49.23] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 122.78MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 39.76MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 60.37MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 178.42MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 27.14MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Adds a clippy disallowed_methods rule to enforce use of
simdutf8::basic::from_utf8 over the std version, fixes all four
existing call sites in process-memory, saluki-components, and
saluki-io, and suppresses the lint in stele/traces/stats.rs where
the serde_with DeserializeFromStr macro generates the call internally.
@thieman thieman force-pushed the thieman/disallow-std-from-utf8 branch from db4458b to 8806ae1 Compare May 11, 2026 09:46
@dd-octo-sts dd-octo-sts Bot added the area/io General I/O and networking. label May 11, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 2a61707 into main May 11, 2026
66 checks passed
dd-octo-sts Bot pushed a commit that referenced this pull request May 11, 2026
## Summary

- Adds a `disallowed_methods` Clippy rule in `clippy.toml` to enforce `simdutf8::basic::from_utf8` over `std::str::from_utf8` / `core::str::from_utf8`
- Fixes the three existing call sites in `process-memory` and `saluki-components` (adds `simdutf8` as a dependency to both crates)
- Suppresses the lint at module level in `stele/traces/stats.rs` where the `serde_with::DeserializeFromStr` proc macro generates code that calls `core::str::from_utf8` internally

## Test plan

- Pre-commit Clippy check passes (`make check-all`)
- Any future use of `std::str::from_utf8` will be a hard Clippy error

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: travis.thieman <travis.thieman@datadoghq.com> 2a61707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/components Sources, transforms, and destinations. area/io General I/O and networking. area/memory Memory bounds and memory management. mergequeue-status: done transform/trace-obfuscation Trace Obfuscation synchronous transform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants