fix(core): support cmd_port configuration#1648
Merged
Merged
Conversation
dd-octo-sts
Bot
added
area/components
Binary Size Analysis (Agent Data Plane)Target: 65e22e8 (baseline) vs bd44747 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
anyhow |
+7.20 KiB | 213 |
agent_data_plane::internal::env |
+6.73 KiB | 8 |
serde_core |
+5.35 KiB | 39 |
agent_data_plane::cli::run |
-5.28 KiB | 3 |
prost |
+5.12 KiB | 39 |
datadog_protos::agent_include::datadog |
-4.67 KiB | 15 |
core |
-4.59 KiB | 828 |
anon.7be77364b2cdf5e5c03d159c6b1987e4.89.llvm.3318723889602329747 |
+3.64 KiB | 1 |
anon.05044b273a7e4a8d31259722e79fc658.47.llvm.15667338004991869279 |
-3.64 KiB | 1 |
datadog_agent_commons::ipc::client |
-3.23 KiB | 6 |
[Unmapped] |
-2.78 KiB | 1 |
[sections] |
-2.58 KiB | 7 |
figment |
+2.56 KiB | 33 |
alloc |
-2.55 KiB | 33 |
anon.87a2297166168b76c5f1c8108bafdda1.185.llvm.13166977885946176876 |
-2.02 KiB | 1 |
anon.6d21e526c2fa71538e7f35aceb55356c.133.llvm.14999123421166486080 |
+2.02 KiB | 1 |
http |
+1.97 KiB | 13 |
anon.f4a4d7929bfefaa651e3226fa8b73b92.73.llvm.17518122362303660564 |
+1.33 KiB | 1 |
anon.2b92b43974578b84151e0f84413bdd4c.42.llvm.17568915320350933959 |
-1.24 KiB | 1 |
anon.84900be1ab6f3eca8ebaa12de8b168ee.366.llvm.12299157744426248598 |
+1.22 KiB | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
+101% +19.4Ki +102% +19.3Ki agent_data_plane::internal::env::workload::build_collector::_{{closure}}::h9a138921739c9fec
+104% +16.8Ki +104% +16.8Ki agent_data_plane::internal::env::ADPEnvironmentProvider::from_configuration::_{{closure}}::hbae72b2caa5b8ec4
[NEW] +14.5Ki [NEW] +14.4Ki _<backon::retry::Retry<B,T,E,Fut,FutureFn,SF$C&C$NF,AF> as core::future::future::Future>::poll::h5a78146449c23d94
+568% +4.55Ki +656% +4.55Ki alloc::collections::btree::map::BTreeMap<K,V,A>::insert::hc2d9aa1289ff4bd3
+567% +4.40Ki +659% +4.40Ki alloc::collections::btree::map::BTreeMap<K,V,A>::insert::h31b894476c54be3b
[NEW] +3.91Ki [NEW] +2.92Ki core::ptr::drop_in_place<backon::retry::Retry<backon::backoff::constant::ConstantBackoff,tonic::service::interceptor::InterceptedService<tonic::transport::channel::Channel,datadog_agent_commons::ipc::client::bearer_auth::BearerAuthInterceptor>,anyhow::Error,datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}}::{{closure}},datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}},backon::sleep::TokioSleeper,fn$LP$&anyhow::Error$RP$ .> bool,datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}},fn$LP$&anyhow::Error,core::option::Option<core::time::Duration>$RP$ .> core::option::Option<core::time::Duration>>>::h5a2a7ac2d9e33c20
[NEW] +3.64Ki [NEW] +16 anon.7be77364b2cdf5e5c03d159c6b1987e4.89.llvm.3318723889602329747
+841% +3.34Ki +10e2% +3.34Ki prost::encoding::merge_loop::hd552862d292b1917
+226% +3.15Ki [ = ] 0 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_frame::MapFrame<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::workloadmeta::WorkloadmetaStreamResponse>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::workloadmeta::WorkloadmetaStreamResponse>>::{{closure}}>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::workloadmeta::WorkloadmetaStreamResponse>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::workloadmeta::WorkloadmetaStreamResponse>>::{{closure}}>,tonic::status::Status::map_error<tonic::status::Status>$GT
+238% +2.88Ki [ = ] 0 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_frame::MapFrame<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::ConfigEvent>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::ConfigEvent>>::{{closure}}>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::ConfigEvent>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::ConfigEvent>>::{{closure}}>>::h1e2ae73d10a7b11f
+0.1% +2.29Ki -0.0% -1.28Ki [4127 Others]
[DEL] -2.34Ki [DEL] -1.92Ki _<hyper_timeout::TimeoutConnector<T> as tower_service::Service<http::uri::Uri>>::call::_{{closure}}::hf03b51a496e3d39c
-43.1% -2.78Ki [ = ] 0 [Unmapped]
[DEL] -2.92Ki [DEL] -2.75Ki _<datadog_protos::agent_include::datadog::autodiscovery::Config as prost::message::Message>::merge_field::hc4348a08c568c2e9
[DEL] -3.64Ki [DEL] -16 anon.05044b273a7e4a8d31259722e79fc658.47.llvm.15667338004991869279
[DEL] -3.85Ki [DEL] -2.86Ki core::ptr::drop_in_place<backon::retry::Retry<backon::backoff::constant::ConstantBackoff,tonic::service::interceptor::InterceptedService<tonic::transport::channel::Channel,datadog_agent_commons::ipc::client::bearer_auth::BearerAuthInterceptor>,anyhow::Error,datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}}::{{closure}},datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}},backon::sleep::TokioSleeper,fn$LP$&anyhow::Error$RP$ .> bool,datadog_agent_commons::ipc::client::RemoteAgentClient::from_configuration::{{closure}}::{{closure}},fn$LP$&anyhow::Error,core::option::Option<core::time::Duration>$RP$ .> core::option::Option<core::time::Duration>>>::hce20edb9031fa6b1
[DEL] -4.89Ki [DEL] -4.59Ki alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::hffe2f051523f88f2
[DEL] -5.05Ki [DEL] -4.75Ki alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::h828ebe9945b56d69
-3.6% -5.31Ki -3.6% -5.31Ki agent_data_plane::cli::run::handle_run_command::_{{closure}}::haf0764c1bab35be1
[DEL] -14.3Ki [DEL] -14.1Ki _<backon::retry::Retry<B,T,E,Fut,FutureFn,SF$C&C$NF,AF> as core::future::future::Future>::poll::h10ab70c415d098f0
-51.3% -29.4Ki -51.4% -29.4Ki agent_data_plane::internal::env::workload::RemoteAgentWorkloadProvider::from_configuration::_{{closure}}::h2eb61ab2f373fb14
+0.0% +4.44Ki -0.0% -1.21Ki TOTAL
tobz
approved these changes
May 13, 2026
When cmd_port is set to a non-default value in datadog.yaml, ADP now reads it and connects to the correct Agent IPC port instead of the hardcoded default 5001. cmd_port takes precedence over agent_ipc_endpoint when both are set. The endpoint is resolved at call time in RemoteAgentClientConfiguration::endpoint(). Adds an integration test named adp-cmd-port.
webern
force-pushed
the
matt.briggs/issue-1645
branch
from
c633d26 to
bd44747
Compare
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
May 13, 2026
## Summary When cmd_port is set to a non-default value in datadog.yaml, ADP now reads it and connects to the correct Agent IPC port instead of the hardcoded default 5001. cmd_port takes precedence over agent_ipc_endpoint when both are set. The endpoint is resolved at call time in RemoteAgentClientConfiguration::endpoint(). Adds an integration test named adp-cmd-port. ## Change Type - [x] Bug fix - [x] New feature ## How did you test this PR? New integration test. ## References Closes #1645 Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com> fb3fdf0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When cmd_port is set to a non-default value in datadog.yaml, ADP now reads it and connects to the correct Agent IPC port instead of the hardcoded default 5001.
cmd_port takes precedence over agent_ipc_endpoint when both are set. The endpoint is resolved at call time in
RemoteAgentClientConfiguration::endpoint().
Adds an integration test named adp-cmd-port.
Change Type
How did you test this PR?
New integration test.
References
Closes #1645