chore(dogstatsd): add support for dogstatsd_context_expiry_seconds#1650
Merged
Conversation
tobz
added
the
type/chore
dd-octo-sts
Bot
added
area/components
Binary Size Analysis (Agent Data Plane)Target: fb3fdf0 (baseline) vs 6e1ca86 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
tower |
-4.69 KiB | 15 |
saluki_io::net::util |
+4.13 KiB | 3 |
core |
-3.15 KiB | 644 |
saluki_io::deser::framing |
+3.15 KiB | 1 |
http_body_util |
+2.65 KiB | 14 |
saluki_components::sources::dogstatsd |
-2.40 KiB | 23 |
crossbeam_channel |
-2.08 KiB | 4 |
tower_layer |
+1.89 KiB | 1 |
anon.fd7b529fe56f46398ecdea2e5e277011.5.llvm.6425510092197803827 |
-1.69 KiB | 1 |
anon.bb6a30149cebda15d8b61928541f6dfa.456.llvm.9067471501927015186 |
+1.69 KiB | 1 |
std |
+1.64 KiB | 6 |
[Unmapped] |
-1.58 KiB | 1 |
anon.022733de89c1b9e4dcd1337b503abb98.1039.llvm.16171459405870212930 |
+1.51 KiB | 1 |
h2 |
+1.49 KiB | 4 |
anon.dd5b1f3bfca0f8b909ebdc618a7bf277.21.llvm.1618916015308137990 |
-1.42 KiB | 1 |
anon.76b10c6ba1f5f88986f9dfd595c03364.22.llvm.18017217637076799424 |
-1.35 KiB | 1 |
anon.f06a3103d0444795408a52e3b4e4e6de.6.llvm.12077248601313944555 |
+1.34 KiB | 1 |
anon.b187eb6dc8b3f143c80dbecbb91de4c1.66.llvm.16087103420286002926 |
-1.33 KiB | 1 |
anon.d2678bcbaf4238fcd297e08325cf4495.35.llvm.5207802880310005362 |
+1.32 KiB | 1 |
anon.7085673481cc83f1b54ec9b36a638a73.3.llvm.16819013267556482521 |
+1.32 KiB | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +18.2Ki [NEW] +18.0Ki _<saluki_components::sources::dogstatsd::DogStatsDConfiguration as saluki_core::components::sources::builder::SourceBuilder>::build::_{{closure}}::h417fb6c2bd9965f4
[NEW] +4.83Ki [NEW] +4.64Ki _<saluki_io::net::util::middleware::retry_circuit_breaker::ResponseFuture<P,F,Request> as core::future::future::Future>::poll::h54feb35fa34fbefe
[NEW] +4.05Ki [NEW] +3.70Ki core::ptr::drop_in_place<saluki_components::sources::dogstatsd::DogStatsDConfiguration>::hf5c0f524c13de77e
+0.0% +1.60Ki +0.1% +3.28Ki [4284 Others]
[NEW] +3.15Ki [NEW] +2.97Ki _<saluki_io::deser::framing::NestedFramer<Inner,Outer> as saluki_io::deser::framing::Framer>::next_frame::h9872b4af11b6685d
[NEW] +2.92Ki [NEW] +2.80Ki saluki_components::sources::dogstatsd::resolver::ContextResolvers::new::h4aead2e78f0554a7
[NEW] +1.97Ki [NEW] +315 core::ptr::drop_in_place<tokio::sync::mpsc::bounded::Permit<saluki_core::topology::interconnect::event_buffer::FixedSizeEventBuffer<1024_usize>>>::h048fd97e097085bc
+296% +1.89Ki +385% +1.89Ki _<tower_layer::stack::Stack<Inner,Outer> as tower_layer::Layer<S>>::layer::hb9e23bcd228e099f
[NEW] +1.69Ki [NEW] +97 anon.bb6a30149cebda15d8b61928541f6dfa.456.llvm.9067471501927015186
+17% +1.64Ki +18% +1.64Ki _<std::io::error::ErrorKind as core::fmt::Debug>::fmt::h6f31d7a057898f75
-46.4% -1.58Ki [ = ] 0 [Unmapped]
[DEL] -1.61Ki [DEL] -1.46Ki _<tower::util::map_request::MapRequestLayer<F> as tower_layer::Layer<S>>::layer::hfc72de87e1a2f5cc
-90.8% -1.64Ki -95.7% -1.64Ki _<&T as core::fmt::Debug>::fmt::h6defbe7231ccc0b3
[DEL] -1.69Ki [DEL] -97 anon.fd7b529fe56f46398ecdea2e5e277011.5.llvm.6425510092197803827
[DEL] -1.97Ki [DEL] -315 core::ptr::drop_in_place<tokio::sync::mpsc::bounded::Permit<saluki_components::sources::otlp::OtlpResource>>::hec5850e6645f78db
-71.0% -2.07Ki -74.3% -2.07Ki crossbeam_channel::flavors::array::Channel<T>::recv::_{{closure}}::hc32a41b3424d63c5
[DEL] -2.94Ki [DEL] -2.83Ki saluki_components::sources::dogstatsd::resolver::ContextResolvers::new::h3a99a60c1ef84507
[DEL] -3.18Ki [DEL] -3.02Ki _<saluki_components::sources::dogstatsd::framer::DsdFramer as saluki_io::deser::framing::Framer>::next_frame::h5b5492ef1d4669f6
[DEL] -4.05Ki [DEL] -3.70Ki core::ptr::drop_in_place<saluki_components::sources::dogstatsd::DogStatsDConfiguration>::h3c9cf99721606cf6
[DEL] -4.79Ki [DEL] -4.64Ki _<tower::limit::concurrency::future::ResponseFuture<F> as core::future::future::Future>::poll::hc82a8bc58d98f9b2
[DEL] -18.2Ki [DEL] -18.0Ki _<saluki_components::sources::dogstatsd::DogStatsDConfiguration as saluki_core::components::sources::builder::SourceBuilder>::build::_{{closure}}::h11f7e705f538dbbd
-0.0% -1.80Ki +0.0% +1.57Ki TOTAL
jszwedko
approved these changes
May 14, 2026
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
dogstatsd_context_expiry_seconds, which controls how long contexts stay cached for in the context resolver for the DogStatsD source.Prior to this PR, we simply hardcoded the expiration to 30 seconds: close enough to the default of 20 seconds in the Datadog Agent, but not the same and not configurable. We now have both the proper default value of 20 seconds and we read the value from the configuration if present. Huzzah!
I made some small cleanup tweaks -- ordering of constants, deduplicating variable usages, etc -- as I was going through the code. They're small, and should be very obvious.
Change Type
How did you test this PR?
References
DADP-72
Closes #1340