chore(agent-data-plane): clean up display name/flavor used when registered via RAR#1658
Merged
Conversation
tobz
added
the
type/chore
Binary Size Analysis (Agent Data Plane)Target: c1313d0 (baseline) vs 0270045 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
[Unmapped] |
-1.74 KiB | 1 |
tower |
+1.38 KiB | 2 |
anon.1f92070954cd764eaf703c4d91d9aa51.110.llvm.4697276323575673218 |
+1.34 KiB | 1 |
anon.008f2eb7666b60adbf212aa1a1a9babf.1039.llvm.1675885107082596853 |
-1.34 KiB | 1 |
anon.dd5b1f3bfca0f8b909ebdc618a7bf277.21.llvm.1618916015308137990 |
+1.24 KiB | 1 |
anon.ff7950eb5cfb17ddfcd9e2b2a5594f26.97.llvm.12774116853458931105 |
-1.24 KiB | 1 |
anon.cef2c965820659cc217e63c0fca83ae7.45.llvm.8368023546332325995 |
-1.23 KiB | 1 |
anon.ff4bc08d9b10773e00ce3c01f8ab2318.684.llvm.507633540418220019 |
+1.23 KiB | 1 |
anon.0e53b40e76a61c92f16686d60014df25.227.llvm.16329846828282783999 |
-1.07 KiB | 1 |
anon.5ae98b8a0921b55cc4b91f64c0ebe109.117.llvm.3313866793015199511 |
+1.07 KiB | 1 |
anon.dc598cb313334a8063f2ebc0eb44ddc0.468.llvm.15303088215705960639 |
-1.06 KiB | 1 |
anon.b1202f6f1c973163089dbf8e70e4de7f.96.llvm.1808416063476283807 |
+1.06 KiB | 1 |
anon.68f0f8614c74ab97a72833e1da197605.815.llvm.11880302753514420722 |
+1002 B | 1 |
anon.0f55d6679d075c395825a3b729bced71.416.llvm.13082800132604442316 |
-1002 B | 1 |
core |
-903 B | 505 |
[sections] |
+880 B | 4 |
anon.dc598cb313334a8063f2ebc0eb44ddc0.45.llvm.15303088215705960639 |
-837 B | 1 |
anon.dcd2065742dc05dc926bcb4a1f03d948.102.llvm.17084958739275293679 |
+836 B | 1 |
anon.fda1b3533837ce22d4b7e19c78568bdb.5.llvm.10246983265954608129 |
-733 B | 1 |
anon.e3bad5810b59ee78b5b0ca4e2a647f33.1.llvm.5939792163410021948 |
+731 B | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +23.3Ki [NEW] +23.1Ki agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::_{{closure}}::h0474e6f20f4293bc
[NEW] +4.10Ki [NEW] +3.88Ki core::ptr::drop_in_place<agent_data_plane::internal::remote_agent::RemoteAgentState>::h988e702550f8f650
[NEW] +3.12Ki [NEW] +2.92Ki core::ptr::drop_in_place<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>::h8f3a27a49abd7454
+0.1% +3.06Ki +0.1% +2.73Ki [2110 Others]
[NEW] +1.99Ki [NEW] +868 core::ptr::drop_in_place<memory_accounting::allocator::Tracked<tracing::instrument::Instrumented<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>>>::hc21d101f5bd13d93
[NEW] +1.63Ki [NEW] +1.39Ki tokio::sync::broadcast::Shared<T>::notify_rx::h5092f01501b2842a
[NEW] +1.61Ki [NEW] +47 _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::h5c6b69b6d857e702
[NEW] +1.60Ki [NEW] +462 core::ptr::drop_in_place<alloc::boxed::Box<tokio::runtime::task::core::Cell<tokio::runtime::blocking::task::BlockingTask<tokio::fs::read::read<&std::path::PathBuf>::{{closure}}::{{closure}}>,tokio::runtime::blocking::schedule::BlockingSchedule>>>::h183c09f7b86d449a
[NEW] +1.56Ki [NEW] +808 core::ptr::drop_in_place<tokio::runtime::task::core::Stage<saluki_common::task::instrument::InstrumentedTask<memory_accounting::allocator::Tracked<tracing::instrument::Instrumented<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>>>>>::hcbc201dde781dbc4
[NEW] +1.42Ki [NEW] +33 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<containerd_protos::containerd_include::containerd::services::namespaces::v1::ListNamespacesRequest>,tokio_stream::stream_ext::map::Map<tokio_stream::once::Once<containerd_protos::containerd_include::containerd::services::namespaces::v1::ListNamespacesRequest>,core::result::Result<containerd_protos::containerd_include::containerd::services::namespaces::v1::ListNamespacesRequest,tonic::status::Status>::Ok>>,tonic::status::Status::map_error<tonic::status::Status>>>::h18819913ef052bd7
[DEL] -1.42Ki [DEL] -33 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentRequest>,tokio_stream::stream_ext::map::Map<tokio_stream::once::Once<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentRequest>,core::result::Result<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentRequest,tonic::status::Status>::Ok>>,tonic::status::Status::map_error<tonic::status::Status>>>::hbfc7b7eee5761dcd
[DEL] -1.44Ki [DEL] -1.33Ki agent_data_plane::internal::remote_agent::RemoteAgentState::new::h20605833b8e943bc
[DEL] -1.56Ki [DEL] -808 core::ptr::drop_in_place<tokio::runtime::task::core::Stage<saluki_common::task::instrument::InstrumentedTask<memory_accounting::allocator::Tracked<tracing::instrument::Instrumented<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>>>>>::h49e23e3385b7e533
[DEL] -1.60Ki [DEL] -462 core::ptr::drop_in_place<alloc::boxed::Box<tokio::runtime::task::core::Cell<tokio::runtime::blocking::task::BlockingTask<tokio::fs::read::read<&std::path::Path>::{{closure}}::{{closure}}>,tokio::runtime::blocking::schedule::BlockingSchedule>>>::h4fce2dbee71f8648
[DEL] -1.61Ki [DEL] -47 _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::hd3a85808fa15fdf4
[DEL] -1.63Ki [DEL] -1.39Ki tokio::sync::broadcast::Shared<T>::notify_rx::h831c179a4c60594c
-25.8% -1.74Ki [ = ] 0 [Unmapped]
[DEL] -1.99Ki [DEL] -868 core::ptr::drop_in_place<memory_accounting::allocator::Tracked<tracing::instrument::Instrumented<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>>>::h8701b8021172fc41
[DEL] -3.12Ki [DEL] -2.92Ki core::ptr::drop_in_place<agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::{{closure}}>::hd608894898f4c15a
[DEL] -3.79Ki [DEL] -3.56Ki core::ptr::drop_in_place<agent_data_plane::internal::remote_agent::RemoteAgentState>::h929af273e8332695
[DEL] -23.3Ki [DEL] -23.1Ki agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::_{{closure}}::hee337c8e45db0c53
+0.0% +216 +0.0% +1.73Ki TOTAL
lucastemb
approved these changes
May 14, 2026
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the names we send over when registering with RAR to match other subagents.
In the Core Agent, a log is emitted whenever a remote agent registers via RAR:
As seen above, ADP was registering in a way where its display/human-friendly name was actually more of a machine-friendly name, and the "flavor" (the machine-friendly variant) was subtly different than other remote agents, using hyphens instead of underscores.
This PR simply fixes that. We derive both the display name and flavor from
saluki-metadata(instead of hardcoding the flavor), and properly format the values as necessary to match other remote agents. After this PR, we see the following:Change Type
How did you test this PR?
Manually ran the
adp-config-streamintegration test before and after making the change, and observed that after the change, the registration log message showed the intended display name and flavor for ADP.References
DADP-2