chore(docs): use contractions for informal tone#1664
Merged
Conversation
This was referenced May 15, 2026
dd-octo-sts
Bot
added
area/core
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Binary Size Analysis (Agent Data Plane)Target: c98a45d (baseline) vs 9efe7d6 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
anon.755e1b24f8a38c62e47609928be63b14.55.llvm.13170408764035601413 |
-3.73 KiB | 1 |
anon.cef2c965820659cc217e63c0fca83ae7.133.llvm.8797144201617903803 |
+3.73 KiB | 1 |
core |
+2.96 KiB | 1480 |
anon.34e98d5ede58f98aef9c0791654836ab.1.llvm.4069546298221457688 |
+1.69 KiB | 1 |
anon.cfa82e444ed029560c86d3bd09bbfe84.1.llvm.1558050583342915113 |
-1.68 KiB | 1 |
anon.240e6872cde4f5279babbc76ce1c985a.2.llvm.7332188793872339937 |
+1.57 KiB | 1 |
anon.8dd6cff5395c4ae0ee7e181232f8f4d7.3.llvm.5040413938740047295 |
-1.57 KiB | 1 |
anon.210c875deb8dcc7f96e2cfcbd9e565c7.25.llvm.17043991802426554815 |
+1.52 KiB | 1 |
anon.9b4c70b795ecf8943bc40120410ae4dc.56.llvm.18083193562899761219 |
+1.52 KiB | 1 |
anon.21d5539572a42ad38e013a9af051c05a.8.llvm.5173826906676495688 |
-1.52 KiB | 1 |
anon.856f29a1542878aca71aaff03c79625f.73.llvm.10080610394013852120 |
-1.52 KiB | 1 |
anon.c1c1d4201d5453d8addd514e97504aaa.15.llvm.8761148779664750621 |
+1.50 KiB | 1 |
anon.21d5539572a42ad38e013a9af051c05a.6.llvm.5173826906676495688 |
-1.50 KiB | 1 |
anon.6c77e63edb98769f0f738df7aa3fc435.18.llvm.13772004139671045516 |
+1.50 KiB | 1 |
anon.0ca6981047c63376b0a8100693147a33.3.llvm.16042516048820772636 |
-1.50 KiB | 1 |
anon.9630b83d6e0ca6a7304fba6d88808550.1.llvm.11080642961215969193 |
-1.32 KiB | 1 |
anon.e150d2ec45d4d29231c94a8b91731438.165.llvm.17721115258038591946 |
+1.32 KiB | 1 |
anon.3a83a7aa436fbeebb17edc20a60b4971.433.llvm.16554411823225781783 |
+1.25 KiB | 1 |
anon.755e1b24f8a38c62e47609928be63b14.392.llvm.9038243899099302964 |
+1.25 KiB | 1 |
anon.856f29a1542878aca71aaff03c79625f.81.llvm.10080610394013852120 |
-1.24 KiB | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +3.73Ki [NEW] +16 anon.cef2c965820659cc217e63c0fca83ae7.133.llvm.8797144201617903803
[NEW] +3.34Ki [NEW] +47 _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::h4e59e781aa522757
[NEW] +1.74Ki [NEW] +33 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<otlp_protos::otlp_include::opentelemetry::proto::collector::trace::v1::ExportTraceServiceResponse>,tokio_stream::once::Once<core::result::Result<otlp_protos::otlp_include::opentelemetry::proto::collector::trace::v1::ExportTraceServiceResponse,tonic::status::Status>>>,tonic::status::Status::map_error<tonic::status::Status>>>::hfda0d8aaa17b2a4c
[NEW] +1.69Ki [NEW] +97 anon.34e98d5ede58f98aef9c0791654836ab.1.llvm.4069546298221457688
[NEW] +1.60Ki [NEW] +462 core::ptr::drop_in_place<alloc::boxed::Box<tokio::runtime::task::core::Cell<tokio::runtime::blocking::task::BlockingTask<tokio::fs::read_to_string::read_to_string<&std::path::Path>::{{closure}}::{{closure}}>,tokio::runtime::blocking::schedule::BlockingSchedule>>>::h93c753d37426a2d9
[NEW] +1.57Ki [NEW] +77 anon.240e6872cde4f5279babbc76ce1c985a.2.llvm.7332188793872339937
[NEW] +1.54Ki [NEW] +1.31Ki tokio::sync::broadcast::Shared<T>::notify_rx::hfde4c12586a22f46
+0.0% +1.53Ki [ = ] 0 [8571 Others]
[NEW] +1.52Ki [NEW] +22 anon.210c875deb8dcc7f96e2cfcbd9e565c7.25.llvm.17043991802426554815
[NEW] +1.52Ki [NEW] +22 anon.9b4c70b795ecf8943bc40120410ae4dc.56.llvm.18083193562899761219
[NEW] +1.50Ki [NEW] +92 anon.c1c1d4201d5453d8addd514e97504aaa.15.llvm.8761148779664750621
[DEL] -1.50Ki [DEL] -92 anon.21d5539572a42ad38e013a9af051c05a.6.llvm.5173826906676495688
[DEL] -1.52Ki [DEL] -22 anon.21d5539572a42ad38e013a9af051c05a.8.llvm.5173826906676495688
[DEL] -1.52Ki [DEL] -22 anon.856f29a1542878aca71aaff03c79625f.73.llvm.10080610394013852120
[DEL] -1.55Ki [DEL] -1.31Ki tokio::sync::broadcast::Shared<T>::notify_rx::h6d4c731163919e60
[DEL] -1.57Ki [DEL] -77 anon.8dd6cff5395c4ae0ee7e181232f8f4d7.3.llvm.5040413938740047295
[DEL] -1.59Ki [DEL] -462 core::ptr::drop_in_place<alloc::boxed::Box<tokio::runtime::task::core::Cell<tokio::runtime::blocking::task::BlockingTask<tokio::fs::read::read<&std::path::Path>::{{closure}}::{{closure}}>,tokio::runtime::blocking::schedule::BlockingSchedule>>>::hb49d4b30cb4531cc
[DEL] -1.68Ki [DEL] -97 anon.cfa82e444ed029560c86d3bd09bbfe84.1.llvm.1558050583342915113
[DEL] -1.74Ki [DEL] -33 core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<tonic::codec::encode::EncodeBody<tonic_prost::codec::ProstEncoder<otlp_protos::otlp_include::opentelemetry::proto::collector::metrics::v1::ExportMetricsServiceResponse>,tokio_stream::once::Once<core::result::Result<otlp_protos::otlp_include::opentelemetry::proto::collector::metrics::v1::ExportMetricsServiceResponse,tonic::status::Status>>>,tonic::status::Status::map_error<tonic::status::Status>>>::h21fc08b01cc7befc
[DEL] -3.32Ki [DEL] -47 _<http_body_util::combinators::map_err::MapErr<B,F> as http_body::Body>::size_hint::hc4e1fd9169c57358
[DEL] -3.73Ki [DEL] -16 anon.755e1b24f8a38c62e47609928be63b14.55.llvm.13170408764035601413
+0.0% +1.56Ki [ = ] 0 TOTAL
tobz
added
the
type/chore
aqian01
approved these changes
May 15, 2026
tobz
force-pushed
the
tobz/docs-cleanup-contractions
branch
from
4109b7b to
9efe7d6
Compare
atanzu
approved these changes
May 15, 2026
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all violations for the
Google.Contractionsstyle rule in Vale. Specifically, replacing formal usages of two-word contractions:don'tinstead ofdoes not, and so on. The majority of contractions in play here are "negation contractions", which Google's Style Guide provides a meaningful justification for:This drops the number of Vale violations for the
Google.Contractionsrule from 786 to five.Change Type
How did you test this PR?
make check-docsbefore and after and verified the drop in violation count for theGoogle.Contractionsrule.make check-clippypasses cleanly.References
N/A