-
Notifications
You must be signed in to change notification settings - Fork 0
fix: enable default datadog-fips features from dogstatsd #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable default datadog-fips features from dogstatsd #15
Conversation
f39a2b5 to
0826e48
Compare
crates/dogstatsd/Cargo.toml
Outdated
| regex = { version = "1.10.6", default-features = false } | ||
| zstd = { version = "0.13.3", default-features = false } | ||
| datadog-fips = { path = "../datadog-fips", default-features = false } | ||
| datadog-fips = { path = "../datadog-fips", default-features = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be incorrect. we may need to select which features to include, default or not default. i'd say if you need the default feature from datadog-fips it would be better to add it to the default feature list on line 35 below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about setting the default features from datadog-serverless-compat?
| dogstatsd = { path = "../dogstatsd", default-features = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that shouldn't mess with bottlecap, i think. seems fine from that perspective.
apiarian-datadog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine from the bottlecaps and fips-ish perspective
What does this PR do?
Enable default
datadog-fipsfeatures fromdogstatsd.Motivation
Error when building
datadog-serverless-compatwithout thereqwest/rustls-tlsfeature:serverless-components/crates/datadog-fips/Cargo.toml
Line 16 in 619d378
Additional Notes
ubuntu-24.04-armbuild for Datadog Serverless Compat since this architecture is not supported by Azure Functions or Google Cloud Run Functions at this timefail-fasttofalsefor Github Actions to false to allow for all jobs to run independently of other failures.Describe how to test/QA your changes
Added build step for
datadog-serverless-compatto CI to catch build errors in the future.