feat: Add configurable compression level to DogStatsD metrics submission #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add configurable compression level to DogStatsD metrics submission Add compression_level field to FlusherConfig and DdApi to enable configurable zstd compression for metrics payloads.
litianningdatadog
changed the title
litianningdatadog
requested review from
astuyve and
lym953
and removed request for
lym953
feat: Add configurable compression level to DogStatsD metrics submission Add compression_level field to FlusherConfig and DdApi to enable configurable zstd compression for metrics payloads.
duncanista
reviewed
Aug 29, 2025
| timeout: DOGSTATSD_TIMEOUT_DURATION, | ||
| retry_strategy: RetryStrategy::LinearBackoff(3, 1), | ||
| compression_level: CompressionLevel::try_from(6) | ||
| .expect("failed to create compression level"), |
Contributor
There was a problem hiding this comment.
expect should not be used unless infallible, let's use either an unwrap_or_default or another way to fallback to the default
duncanista
approved these changes
Aug 29, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Left a comment, but overall everything else LGTM
…ning.li/SVLS-7461
…ning.li/SVLS-7461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://datadoghq.atlassian.net/browse/SVLS-7461
feat: Add configurable compression level to DogStatsD metrics submission
Motivation
feat: Add configurable compression level to DogStatsD metrics submission
Add compression_level field to FlusherConfig and DdApi to enable configurable zstd compression for metrics payloads.
This change enables Bottlecap configuration integration in a future commit.
Describe how to test/QA your changes
Unit test coverage.