Skip to content

[SVLS-6337] Shut down trace agent if resource group can't be determined #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2025
Merged

[SVLS-6337] Shut down trace agent if resource group can't be determined #39

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f616472
Shut down trace agent if resource group can't be determined
kathiehuang Sep 25, 2025
efe6788
Add regex package and run cargo fmt
kathiehuang Sep 25, 2025
cd2aa57
Just check WEBSITE_SKU env var instead of repeating libdatadog regex …
kathiehuang Sep 25, 2025
deb2062
nit: ran cargo fmt
kathiehuang Sep 25, 2025
caa7e5c
Remove unused regex crate from datadog-trace-agent
kathiehuang Sep 26, 2025
e89748c
Fix tests
kathiehuang Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 49 additions & 4 deletions crates/datadog-trace-agent/src/env_verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ const AZURE_WINDOWS_FUNCTION_ROOT_PATH_STR: &str = "C:\\home\\site\\wwwroot";
const AZURE_HOST_JSON_NAME: &str = "host.json";
const AZURE_FUNCTION_JSON_NAME: &str = "function.json";

// Azure environment variables for Flex consumption plan detection
const DD_AZURE_RESOURCE_GROUP: &str = "DD_AZURE_RESOURCE_GROUP";
const WEBSITE_SKU: &str = "WEBSITE_SKU";

#[derive(Default, Debug, Deserialize, Serialize, Eq, PartialEq)]
pub struct GCPMetadata {
pub instance: GCPInstance,
Expand Down Expand Up @@ -242,6 +246,15 @@ async fn get_gcp_metadata_from_body(body: hyper_migration::Body) -> anyhow::Resu
Ok(gcp_metadata)
}

/// Checks if we're running in Azure Flex Consumption plan without DD_AZURE_RESOURCE_GROUP set
/// This would cause billing issues, so we should shut down the trace agent
fn is_azure_flex_without_resource_group() -> bool {
env::var(WEBSITE_SKU)
.map(|sku| sku == "FlexConsumption")
.unwrap_or(false)
&& env::var(DD_AZURE_RESOURCE_GROUP).is_err()
}

async fn verify_azure_environment_or_exit(os: &str) {
let now = Instant::now();
match ensure_azure_function_environment(Box::new(AzureVerificationClientWrapper {}), os).await {
Expand All @@ -253,6 +266,15 @@ async fn verify_azure_environment_or_exit(os: &str) {
process::exit(1);
}
}

// Check for Azure Flex Consumption plan without DD_AZURE_RESOURCE_GROUP
if is_azure_flex_without_resource_group() {
error!(
Copy link
Contributor

@apiarian-datadog apiarian-datadog Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what log level does this use? what amount of logging would it cause?

Copy link
Contributor Author

@kathiehuang kathiehuang Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the pattern of how other parts of this file handles errors, but I'm a little confused because in the Azure logs, the error is being mapped to a severityLevel of 1, but Azure docs says errors should be severity level 3.
image

For amount of logging, it seems like it logs this error whenever the Azure Function app instance starts (happens a couple logs after "Initializing Warm up Extension"). But it seems like the trace agent keeps trying to restart so a lot of logs get outputted that look like these:
image

I'm a little bit confused but happy to call about this!

"Azure Flex Consumption plan detected without DD_AZURE_RESOURCE_GROUP set. \
Please add your resource group name as an environment variable called `DD_AZURE_RESOURCE_GROUP` in Azure App settings."
);
process::exit(1);
}
debug!(
"Time taken to verify Azure Functions env: {} ms",
now.elapsed().as_millis()
Expand Down Expand Up @@ -337,13 +359,14 @@ mod tests {
use hyper::{body::Bytes, Response, StatusCode};
use serde_json::json;
use serial_test::serial;
use std::{fs, path::Path, time::Duration};
use std::{env, fs, path::Path, time::Duration};

use crate::env_verifier::{
ensure_azure_function_environment, ensure_gcp_function_environment,
get_region_from_gcp_region_string, AzureVerificationClient, AzureVerificationClientWrapper,
GCPInstance, GCPMetadata, GCPProject, GoogleMetadataClient, AZURE_FUNCTION_JSON_NAME,
AZURE_HOST_JSON_NAME,
get_region_from_gcp_region_string, is_azure_flex_without_resource_group,
AzureVerificationClient, AzureVerificationClientWrapper, GCPInstance, GCPMetadata,
GCPProject, GoogleMetadataClient, AZURE_FUNCTION_JSON_NAME, AZURE_HOST_JSON_NAME,
DD_AZURE_RESOURCE_GROUP, WEBSITE_SKU,
};

use super::{EnvVerifier, ServerlessEnvVerifier};
Expand Down Expand Up @@ -615,4 +638,26 @@ mod tests {

assert_eq!(files, vec![AZURE_HOST_JSON_NAME]);
}

#[test]
#[serial]
fn test_is_azure_flex_without_resource_group_true() {
env::set_var(WEBSITE_SKU, "FlexConsumption");
assert!(is_azure_flex_without_resource_group());
}

#[test]
#[serial]
fn test_is_azure_flex_without_resource_group_false_resource_group_set() {
env::set_var(DD_AZURE_RESOURCE_GROUP, "test-resource-group");
env::set_var(WEBSITE_SKU, "FlexConsumption");
assert!(!is_azure_flex_without_resource_group());
}

#[test]
#[serial]
fn test_is_azure_flex_without_resource_group_false_not_flex() {
env::set_var(WEBSITE_SKU, "ElasticPremium");
assert!(!is_azure_flex_without_resource_group());
}
}
Loading