Skip to content

Conversation

@kathiehuang
Copy link
Contributor

What does this PR do?

  • Updates the libdatadog commit hash in crates/datadog-trace-agent/Cargo.toml
    • This adds logic to check for DD_AZURE_RESOURCE_GROUP in Azure flex consumption functions. Without that env var, the resource group span attribute will be set to unknown. Before, the resource group span attribute would be set to flex, which is incorrect and messes up the resource id and billing
  • Had to add an override for the stringmetrics crate when checking 3rd party licenses - this is because libdatadog is using a tool that has less stringent checks than the rust license tool this repo uses

Motivation

Need to build updated binary for serverless compat layers

Describe how to test/QA your changes

Copy link
Collaborator

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Just one minor nit

@kathiehuang
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 2, 2025

View all feedbacks in Devflow UI.

2025-10-02 15:04:45 UTC ℹ️ Start processing command /merge


2025-10-02 15:04:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-10-02 15:46:10 UTC ⚠️ MergeQueue: This merge request build was cancelled

kathie.huang@datadoghq.com cancelled this merge request build

@kathiehuang
Copy link
Contributor Author

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 2, 2025

View all feedbacks in Devflow UI.

2025-10-02 15:46:04 UTC ℹ️ Start processing command /remove


2025-10-02 15:46:07 UTC ℹ️ Devflow: /remove

@kathiehuang kathiehuang merged commit fcf1d53 into main Oct 2, 2025
26 of 27 checks passed
@kathiehuang kathiehuang deleted the kathie.huang/update-libdatadog-hash branch October 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants