Conversation
Collaborator
duncanpharvey
left a comment
duncanpharvey
left a comment
There was a problem hiding this comment.
The build is failing in CI, can you look into why those failures are happening? It may be that something else changed in libdatadog.
Can you share in the PR description how you tested this build to verify it works as expected?
| [dependencies] | ||
| datadog-trace-agent = { path = "../datadog-trace-agent" } | ||
| libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "435107c245112397914935c0f7148a18b91cafc6" } | ||
| libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog/", rev = "660c550b6311a209d9cf7de762e54b6b7109bcdb" } |
Collaborator
There was a problem hiding this comment.
Does the forward slash at the end of libdatadog need to be added? The dependencies have been pulled in just fine without it. Same comment applies for other changes
Comment on lines
29
to
31
| datadog-fips = { path = "../datadog-fips" } | ||
| reqwest = { version = "0.12.23", features = ["json", "http2"], default-features = false } | ||
| bytes = "1.10.1" |
Collaborator
There was a problem hiding this comment.
Seems like the removal of these dependencies may be causing the build failures.
duncanpharvey
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the commit hash for
libdatadoglibraries, in preparation of a new serverless compatability layer release.libdatadog PR
Motivation
As we build out support for Azure APIM, we need to ensure the compat layers are not adding AAS tags to the APIM generated spans. This follows the same tagging behavior as APIGW and Lambda.
APMSVLS-353
Epic
Additional Notes
Describe how to test/QA your changes