chore: Fix npm publish GitHub Action

[lym953]

Motivation

The GitHub Action added in #540 failed to publish the npm package on release event. GitHub Action log says

error No token found and can't prompt for login when running with --non-interactive.

What does this PR do?

Change the way to set npm publish token, following this discussion:
actions/setup-node#81 (comment)

Testing Guidelines

Steps

1. Add this to publish.yml

on:
  release:
    types: [created]
+ push:

2. Push the commit

Result

The previous error is gone, and a new error appears:

Couldn't publish package: "https://registry.npmjs.org/serverless-plugin-datadog: You cannot publish over the previously published versions: 5.74.0."

I think we can assume it's a success.

GitHub Action log

Additional Notes

Types of changes

• Bug fix
• New feature
• Breaking change
• Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

• This PR's description is comprehensive
• This PR contains breaking changes that are documented in the description
• This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
• This PR impacts documentation, and it has been updated (or a ticket has been logged)
• This PR's changes are covered by the automated tests
• This PR collects user input/sensitive content into Datadog

[purple4reina]

Hmm, actually on second thought, I feel a bit uneasy about writing a secret to disk like this. Can we add a step that will remove the npmrc file? Make sure it executes on success and failure?

[lym953]

@purple4reina I changed to another approach mentioned in another comment, which looks more secure.

[purple4reina]

love it

[lym953]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-21 20:29:54 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 2m.