Conversation
…d validation helpers
…w for checking docs compilation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c33589909
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }; | ||
|
|
||
| pub ExtensionUrnDecl: ExtensionUrnDeclaration = { | ||
| <anchor:UrnAnchor> ":" <urn:UrnValue> => ExtensionUrnDeclaration::new(anchor, urn), |
There was a problem hiding this comment.
Reject oversized extension anchors without panicking
The new ExtensionUrnDecl/ExtensionDecl grammar routes extension anchors through Anchor/UrnAnchor, which currently convert with parse::<u32>().expect(...); inputs like @4294967296: ... or #1 @4294967296: fn will now panic the parser process instead of returning a structured parse error. Before this migration these declaration lines used fallible parsing (map_err) and surfaced normal MessageParseErrors, so this introduces a crash-on-malformed-input regression.
Useful? React with 👍 / 👎.
| r"\s*" => { }, | ||
| r"-?[0-9]+\.[0-9]+" => FLOAT, | ||
| r"-?[0-9]+" => INT, | ||
| r"([A-Za-z][A-Za-z0-9+.\-]*://[^\s]+)|(/[^\s]+)" => URN_VALUE, |
There was a problem hiding this comment.
Broaden URN tokenization for extension declarations
The new URN_VALUE lexer rule only accepts URL-like scheme://..., absolute /..., identifiers, or quoted names, so URNs such as urn:substrait:functions_arithmetic (previously accepted because everything after : was treated as URN text) now fail to parse. This is a behavioral regression in extension parsing and can break parse/textify round-trips for plans containing non-URL URN formats.
Useful? React with 👍 / 👎.
This builds on #64:
Lowertrait topub(crate)and simplify imports