Add conditional Sendable conformances#18
Merged
Merged
Conversation
alanf
approved these changes
May 12, 2026
alanf
left a comment
There was a problem hiding this comment.
LGTM with a question about phantom copy
| } | ||
| } | ||
|
|
||
| // `Destination` is phantom — `RelationshipMany` only stores `[ResourceIdentifier]` — so the |
There was a problem hiding this comment.
//
Destinationis phantom
I have no idea what this means...what does phantom mean here?
Contributor
Author
There was a problem hiding this comment.
Destination is not really stored inside RelationshipMany, it is only here to provide the ID type from the ResourceLinkageProviding. I think it fits the definition of Swift Phantom Types, but happy to change that if you think that's not relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Add conditional
Sendableconformances.Context
With Swift 6's strict concurrency checking (and Xcode 26.5's default warnings), a value produced on the main actor and handed to a non-isolated
@Sendableclosure must conform toSendable. None of the library's resource types declaredSendable, which forced every downstream app to add per-target retroactive conformances such as:Conditional Sendable belongs in the library, mirroring how it already conditionally provides Equatable and Codable.
Summary of Changes
the generic parameters that show up in stored properties.
for Equatable).
How to Test
N/A — covered by the new tests.
Demo