Skip to content

[parametric] Enable 128-bit TraceId tests for Java client#1021

Merged
PerfectSlayer merged 2 commits into
mainfrom
bbujon/parametric-java-6to7
Apr 17, 2023
Merged

[parametric] Enable 128-bit TraceId tests for Java client#1021
PerfectSlayer merged 2 commits into
mainfrom
bbujon/parametric-java-6to7

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

Description

Enable 128-bit TraceId tests for Java client.

Note: Those changes was tested against a Java tracer dev build and will only be merged once the 128-bit TraceId feature is merged and released. They can be reviewed in the same time.

Workflow

  1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! ❤️

@PerfectSlayer PerfectSlayer added the java Pull requests that update Java code label Mar 30, 2023
@PerfectSlayer PerfectSlayer requested review from a team and Kyle-Verhoog as code owners March 30, 2023 06:57
@PerfectSlayer PerfectSlayer changed the title Enable 128-bit TraceId tests for Java client [parametric] Enable 128-bit TraceId tests for Java client Mar 30, 2023
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-java-6to7 branch 2 times, most recently from 39c3e3a to 5791ce1 Compare April 5, 2023 08:18
Display log file name rather than getting <tempfile._TemporaryFileWrapper object at 0x105d3b910> string representation.
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-java-6to7 branch from 5791ce1 to 7a5917d Compare April 17, 2023 11:29
@PerfectSlayer PerfectSlayer merged commit 6041f7c into main Apr 17, 2023
@PerfectSlayer PerfectSlayer deleted the bbujon/parametric-java-6to7 branch April 17, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants