Skip to content

Extract parametric tracer version#1589

Merged
robertomonteromiguel merged 17 commits intomainfrom
robertomonteromiguel/parametric_tracer_version
Sep 20, 2023
Merged

Extract parametric tracer version#1589
robertomonteromiguel merged 17 commits intomainfrom
robertomonteromiguel/parametric_tracer_version

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

Description

We need to know the version of the tracer under test before running the tests, to make the @missing_feature annotations work.

Motivation

In python need to ignore tests for specific versions of tracer

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@robertomonteromiguel robertomonteromiguel changed the title Fix parametric tracer version for python Extract parametric tracer version Sep 14, 2023
@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review September 14, 2023 10:01
@robertomonteromiguel robertomonteromiguel requested a review from a team September 14, 2023 10:01
Copy link
Copy Markdown
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The common and Java parts look ok to me.

Copy link
Copy Markdown
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ruby: approved

Copy link
Copy Markdown
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for .NET

Comment thread utils/build/docker/ruby/parametric/ddtracer_version.Dockerfile Outdated
Comment thread utils/build/docker/python/parametric/ddtracer_version.Dockerfile Outdated
Comment thread utils/build/docker/dotnet/parametric/ddtracer_version.Dockerfile Outdated
@robertomonteromiguel robertomonteromiguel merged commit 1510b31 into main Sep 20, 2023
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/parametric_tracer_version branch September 20, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants