Skip to content

chore(python): add new FastAPI variant#1663

Merged
christophe-papazian merged 18 commits intomainfrom
christophe-papazian/create_fastapi_variant_for_python
Oct 9, 2023
Merged

chore(python): add new FastAPI variant#1663
christophe-papazian merged 18 commits intomainfrom
christophe-papazian/create_fastapi_variant_for_python

Conversation

@christophe-papazian
Copy link
Copy Markdown
Contributor

Description

add new FastAPI variant to python

Motivation

ASM plan to fully support FastAPI.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@christophe-papazian christophe-papazian marked this pull request as ready for review October 6, 2023 14:49
@christophe-papazian christophe-papazian requested review from a team as code owners October 6, 2023 14:49
@christophe-papazian christophe-papazian marked this pull request as draft October 6, 2023 14:50
@christophe-papazian christophe-papazian marked this pull request as ready for review October 6, 2023 17:12
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request change, and all good to me

Comment thread manifests/python.yml Outdated
@christophe-papazian christophe-papazian merged commit 7e1fa03 into main Oct 9, 2023
@christophe-papazian christophe-papazian deleted the christophe-papazian/create_fastapi_variant_for_python branch October 9, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants