Skip to content

First usage of features decorator#1901

Merged
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/features-decorator
Dec 7, 2023
Merged

First usage of features decorator#1901
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/features-decorator

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Description

Use @features on a simple class

Motivation

Test the new ingestion mechanism

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne marked this pull request as ready for review December 7, 2023 17:09
@cbeauchesne cbeauchesne requested review from a team as code owners December 7, 2023 17:09
@cbeauchesne cbeauchesne merged commit a23aa6e into main Dec 7, 2023
@cbeauchesne cbeauchesne deleted the cbeauchesne/features-decorator branch December 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant