Skip to content

Comments

API Security RC tests#2049

Merged
uurien merged 18 commits intomainfrom
ugaitz/api-sec-rc
Feb 1, 2024
Merged

API Security RC tests#2049
uurien merged 18 commits intomainfrom
ugaitz/api-sec-rc

Conversation

@uurien
Copy link
Contributor

@uurien uurien commented Jan 24, 2024

Motivation

Have tests to check that we are applying Api Security related RC correctly

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@uurien uurien changed the title Something working API Security RC tests Jan 24, 2024
""",
)

appsec_api_security_rc = EndToEndScenario(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uurien uurien force-pushed the ugaitz/api-sec-rc branch 5 times, most recently from 0b26175 to 7e88a19 Compare January 30, 2024 10:22
@uurien uurien force-pushed the ugaitz/api-sec-rc branch from 7e88a19 to 6234ce8 Compare January 30, 2024 13:32
@uurien uurien marked this pull request as ready for review January 30, 2024 14:18
@uurien uurien requested a review from a team January 30, 2024 14:18
@uurien uurien requested review from a team as code owners January 30, 2024 14:18
@cbeauchesne
Copy link
Collaborator

Updating the branch, some issue has been fixed in other PR

@cbeauchesne
Copy link
Collaborator

Approved the framework usage.

It may be useful to request a review from somebody that knows the feature, to review the test logic.

@uurien uurien force-pushed the ugaitz/api-sec-rc branch from 56b4154 to 231b1d1 Compare January 31, 2024 10:56
@uurien uurien merged commit 0ba6681 into main Feb 1, 2024
@uurien uurien deleted the ugaitz/api-sec-rc branch February 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants