Merged
Conversation
cbeauchesne
requested changes
Jan 24, 2024
| """, | ||
| ) | ||
|
|
||
| appsec_api_security_rc = EndToEndScenario( |
Collaborator
There was a problem hiding this comment.
Can you add this new scenario in https://github.com/DataDog/system-tests/blob/main/.github/workflows/ci.yml ?
0b26175 to
7e88a19
Compare
7e88a19 to
6234ce8
Compare
Collaborator
|
Updating the branch, some issue has been fixed in other PR |
cbeauchesne
approved these changes
Jan 31, 2024
Collaborator
|
Approved the framework usage. It may be useful to request a review from somebody that knows the feature, to review the test logic. |
56b4154 to
231b1d1
Compare
cbeauchesne
requested changes
Jan 31, 2024
christophe-papazian
approved these changes
Feb 1, 2024
cbeauchesne
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Have tests to check that we are applying Api Security related RC correctly
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presentsbuild-XXX-imagelabel is present