Skip to content

Allow the main workflow to be called in a distant workflow#2150

Merged
cbeauchesne merged 17 commits intomainfrom
cbeauchesne/distant-call
Feb 15, 2024
Merged

Allow the main workflow to be called in a distant workflow#2150
cbeauchesne merged 17 commits intomainfrom
cbeauchesne/distant-call

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Allow DataDog/system-tests/.github/workflows/system-tests.yml to be called from a different repo

Changes

  • checkout -> force system-tests repo to be checkout, rather than the calling repo

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/distant-call branch from a4aa086 to 41b0f38 Compare February 15, 2024 10:19
@cbeauchesne cbeauchesne changed the title Cbeauchesne/distant call Allow the main workflow to be called in a distant workflow Feb 15, 2024
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/distant-call branch from 2eab633 to c04e1a4 Compare February 15, 2024 10:54
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/distant-call branch 3 times, most recently from 1d8d992 to c7101fe Compare February 15, 2024 15:58
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/distant-call branch from c7101fe to 22228af Compare February 15, 2024 15:59
@cbeauchesne cbeauchesne marked this pull request as ready for review February 15, 2024 19:11
@cbeauchesne cbeauchesne requested a review from a team as a code owner February 15, 2024 19:11
@cbeauchesne cbeauchesne merged commit 959bad9 into main Feb 15, 2024
@cbeauchesne cbeauchesne deleted the cbeauchesne/distant-call branch February 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant