Skip to content

Build docker images if there is a label#2321

Merged
robertomonteromiguel merged 49 commits intomainfrom
robertomonteromiguel/ci_build_images_labels
Apr 18, 2024
Merged

Build docker images if there is a label#2321
robertomonteromiguel merged 49 commits intomainfrom
robertomonteromiguel/ci_build_images_labels

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@robertomonteromiguel robertomonteromiguel added build-lib-injection-app-images Build and push weblog images for lib-injection and removed build-buddies-images labels Apr 10, 2024
@robertomonteromiguel robertomonteromiguel added build-lib-injection-app-images Build and push weblog images for lib-injection and removed build-python-base-images labels Apr 10, 2024
@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review April 11, 2024 08:54
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner April 11, 2024 08:54
@robertomonteromiguel robertomonteromiguel merged commit e388120 into main Apr 18, 2024
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/ci_build_images_labels branch April 18, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-lib-injection-app-images Build and push weblog images for lib-injection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants