Dynamically compute scenarios to run#2408
Merged
cbeauchesne merged 22 commits intomainfrom May 3, 2024
Merged
Conversation
d688e86 to
60cba62
Compare
60cba62 to
d685d07
Compare
d7fa329 to
4513ae4
Compare
4513ae4 to
372e143
Compare
d3ab73c to
089c6f3
Compare
robertomonteromiguel
requested changes
May 2, 2024
Collaborator
robertomonteromiguel
left a comment
There was a problem hiding this comment.
I added some comments/questions.
I think this PR is good for our CI performance, but I also think we are adding a lot of complexity to our pipeline.
robertomonteromiguel
approved these changes
May 3, 2024
Collaborator
Author
|
Edit: Actually use a comma separated list : those inputs needs to be computed by a script, so, technically JSON and a comma-separated list are equally simple. But the second is easier to use for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
tests/folderrun-scenario-groupinputs (lot of them), uses two inputs:scenarios: a list of scenario to runscenarios_groups: a list of scenario groups to runLast note,scenariosandscenarios_groupsare strings, in JSON format, like'["AAA", "BBB"]'. I choose this foirmat, rather a simple comma separated list, to be able to easily use them as matrix inputs in a near future.Edit: Actually use a comma separated list : those inputs needs to be computed by a script, so, technically JSON and a comma-separated list are equally simple. But the second is easier to use for
system-tests.ymlAPI.Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presents[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present