Skip to content

Remote config test API#2586

Merged
cbeauchesne merged 4 commits intomainfrom
cbeauchesne/rc-sequence-api
Jun 24, 2024
Merged

Remote config test API#2586
cbeauchesne merged 4 commits intomainfrom
cbeauchesne/rc-sequence-api

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/rc-sequence-api branch from c490957 to a52eb52 Compare June 21, 2024 17:15
@cbeauchesne cbeauchesne marked this pull request as ready for review June 24, 2024 09:08
@cbeauchesne cbeauchesne requested review from a team as code owners June 24, 2024 09:08
Copy link
Copy Markdown
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbeauchesne cbeauchesne merged commit c386911 into main Jun 24, 2024
@cbeauchesne cbeauchesne deleted the cbeauchesne/rc-sequence-api branch June 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants