Skip to content

OnBoarding: Host and container guardrail testing#2647

Merged
robertomonteromiguel merged 5 commits intomainfrom
robertomonteromiguel/onboarding_nodejs18
Jul 2, 2024
Merged

OnBoarding: Host and container guardrail testing#2647
robertomonteromiguel merged 5 commits intomainfrom
robertomonteromiguel/onboarding_nodejs18

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

Motivation

The feature "guardrail" has been implemented for some languages.
This PR creates a new scenario to test unsupported version of the language.
In this case we are testing node18 for supported language version and node16 to test a unsupported version of the language

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Comment thread utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs.yml Outdated
Comment thread .gitlab-ci.yml
Comment on lines +60 to +61
ONBOARDING_FILTER_WEBLOG: [test-app-nodejs-16]
SCENARIO: [HOST_NOT_SUPPORTED_AUTO_INJECTION]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only start working as expected once the guardrails change is released, won't it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, in the main pipeline the test with node16 are working (using the latest release).

Comment thread utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs-16.yml Outdated
@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review July 2, 2024 15:23
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner July 2, 2024 15:23
@robertomonteromiguel robertomonteromiguel merged commit 0eeee16 into main Jul 2, 2024
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/onboarding_nodejs18 branch July 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants