OnBoarding: Host and container guardrail testing#2647
Merged
robertomonteromiguel merged 5 commits intomainfrom Jul 2, 2024
Merged
OnBoarding: Host and container guardrail testing#2647robertomonteromiguel merged 5 commits intomainfrom
robertomonteromiguel merged 5 commits intomainfrom
Conversation
szegedi
reviewed
Jul 2, 2024
Comment on lines
+60
to
+61
| ONBOARDING_FILTER_WEBLOG: [test-app-nodejs-16] | ||
| SCENARIO: [HOST_NOT_SUPPORTED_AUTO_INJECTION] |
Contributor
There was a problem hiding this comment.
This will only start working as expected once the guardrails change is released, won't it?
Collaborator
Author
There was a problem hiding this comment.
Nop, in the main pipeline the test with node16 are working (using the latest release).
szegedi
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The feature "guardrail" has been implemented for some languages.
This PR creates a new scenario to test unsupported version of the language.
In this case we are testing node18 for supported language version and node16 to test a unsupported version of the language
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presents[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present