start containers in parallel

[rochdev]

Motivation

Containers that don't depend on each other shouldn't have to wait for each other before starting.

Changes

Start containers in parallel. This PR is a replacement for #2670 with less changes and more flexible code to manage interdependencies.

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• If PR title starts with [<language>], double-check that only <language> is impacted by the change
• No system-tests internal is modified. Otherwise, I have the approval from R&P team
• CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added (or removed)?
  • Get a review from R&P team

[cbeauchesne]

If I'm not wrong, buddies also require the proxy (and possibly the agent?)

[cbeauchesne]

This PR is a replacement for #2670 with less changes and more flexible code to manage interdependencies.

Can I close this PR ?

[rochdev]

If I'm not wrong, buddies also require the proxy (and possibly the agent?)

Just saw this and added a dependency on the agent just in case.

Can I close this PR ?

Yes.

[cbeauchesne]

There are still lot of work on this PR, I'm putting it in draft mode to prevent spam in our notifs.

[rochdev]

There are still lot of work on this PR, I'm putting it in draft mode to prevent spam in our notifs.

Can you clarify? Assuming the tests start passing it's actually ready for review.

[datadog-datadog-prod-us1]

Library Vulnerabilities

      

[cbeauchesne]

LGTM. Just need to fix the CI crashes, and some minor changes, and we're good to merge !

[cbeauchesne]

To fix Ci issue on Lib injection :

• WeblogInjectionScenario must join threads
• OpenTelemetryCollectorContainer.start has a wrong return type

[cbeauchesne]

@rochdev i've added two commits :

• A first one that put the circular check in the main thread : having a exception raising inside a thread created an output hard to understand (or would have required to propagate the exception in the main thread). With that, it's the same logic, but easier to understand without extra code.
• And some test cases

I'm waiting for the CI, and if it's all green (or not related, PHP failures expected ... 😭 ) -> merge !

[rochdev]

@cbeauchesne Is everything good? I'm not sure what is going on with all the failures but it doesn't seem like it would be related?

[cbeauchesne]

No it's should not be. Just for my peace of mind, I'd like to have an almost-all-green CI before merging it. Don't worry, I'm taking care of it.