parametric: Adds a feature to track the parity for parametric endpoints#3345
Merged
parametric: Adds a feature to track the parity for parametric endpoints#3345
Conversation
3ab951d to
2d8ad43
Compare
mabdinur
commented
Oct 31, 2024
a5dbdb2 to
5781aa7
Compare
mabdinur
commented
Nov 5, 2024
mabdinur
commented
Nov 5, 2024
mabdinur
commented
Nov 5, 2024
mabdinur
commented
Nov 5, 2024
mabdinur
commented
Nov 5, 2024
mabdinur
commented
Nov 5, 2024
ZStriker19
approved these changes
Nov 5, 2024
mtoffl01
approved these changes
Nov 5, 2024
213b330 to
da757e5
Compare
cbeauchesne
reviewed
Nov 6, 2024
cbeauchesne
reviewed
Nov 6, 2024
mabdinur
commented
Nov 6, 2024
cbeauchesne
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Introduces
parametric_endpoint_parityfeature.The goal of the parametric_endpoint_parity feature is to:
parametric_endpoint_parity.pyChanges
parametric_endpoint_paritytab in the feature parity dashboard in contributing docs. Before introducing new tests developers should be aware of the health and availability of parametric endpoints.Next steps
test_parametric_endpoints.py_TestSpan.span_get_name,_TestSpan.span_get_resource,_TestSpan.span_get_meta,_TestSpan.span_get_metricinterfaces/endpoints. These operations are not supported in most languages. Tests should be refactored to use the test agent to retrieve span data.,_TestOtelSpan.get_name,_TestOtelSpan.get_links` interfaces and parametric endpoints. These operations are not supported in the opentelemetry-api. Tests should be refactored to use the test agent to retrieve span data.APMLibrary.current_spanandAPMLibrary.otel_current_spaninterfaces/endpoints. Retrieving the current active span is not possible in all parametric apps. Many parametric apps are multi-threaded do not store the "current span" as the active span. Spans should always be retrieved by span_id.APMLibrary.http_client_requestendpoint. This endpoint only exists in 1 or 2 apps. It does not test a span/tracer api. Themake_distinct_callweblog endpoint should be used instead.trace/span/start. Most libraries do not support initializing a datadog span with these values. We will provide a alternative mechanisms to apply these values to spans: parametric: Ensure start span endpoints align with the spec #3300Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present