Add tests for Service Extension (Envoy External Processing)#3377
Merged
Add tests for Service Extension (Envoy External Processing)#3377
Conversation
a64f21b to
1ff2cb4
Compare
cbeauchesne
requested changes
Nov 6, 2024
This was referenced Nov 6, 2024
1ff2cb4 to
f0cff55
Compare
e44ce62 to
95c3b2e
Compare
Member
Author
|
It's been some times since we discussed about this.
|
cbeauchesne
requested changes
Dec 23, 2024
bd44002 to
1eb5853
Compare
7 tasks
Collaborator
|
@e-n-0 I've fixed the common-test-code case. Ping me if you need any help to move forward. |
d764377 to
a8727a5
Compare
cbeauchesne
requested changes
Jan 15, 2025
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
Two mall details, then all good
cbeauchesne
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tests the new ASM Integration Service Extension.
Changes
Import tests from APM and ASM that applies to the Service Extension.
The import is using class generation to correctly import tests that should work and skip the ones that will not work.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present