Skip to content

[ruby] Add Rails 7.2 and Rails 8.0 weblogs#3471

Merged
vpellan merged 1 commit intomainfrom
vpellan/add-rails-72-and-80-weblogs
Nov 18, 2024
Merged

[ruby] Add Rails 7.2 and Rails 8.0 weblogs#3471
vpellan merged 1 commit intomainfrom
vpellan/add-rails-72-and-80-weblogs

Conversation

@vpellan
Copy link
Copy Markdown
Contributor

@vpellan vpellan commented Nov 15, 2024

Motivation

Rails 8.0 has been released this week, it is the most used Ruby framework among our clients (and in the Ruby community) so it is important that we support it and see if any of our feature breaks on the newest release of Rails. While doing that, I also saw that we are not running system-tests against Rails 7.2, which still receives frequent updates.

Changes

This PR adds Rails 7.2 and Rails 8.0 weblogs.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@vpellan vpellan requested review from a team as code owners November 15, 2024 16:10
@vpellan vpellan merged commit b1f99fb into main Nov 18, 2024
@vpellan vpellan deleted the vpellan/add-rails-72-and-80-weblogs branch November 18, 2024 09:08
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update utils/scripts/compute-workflow-parameters.py line 91 ? @cbeauchesne please wake up, it has be done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants