Skip to content

[java] Remove useless Docker stage for spring-boot-3-native#3697

Merged
smola merged 1 commit intomainfrom
smola/simplify-native-image-build
Dec 17, 2024
Merged

[java] Remove useless Docker stage for spring-boot-3-native#3697
smola merged 1 commit intomainfrom
smola/simplify-native-image-build

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Dec 16, 2024

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola marked this pull request as ready for review December 16, 2024 16:57
@smola smola requested review from a team as code owners December 16, 2024 16:57
@smola smola merged commit d4d6833 into main Dec 17, 2024
@smola smola deleted the smola/simplify-native-image-build branch December 17, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants