Skip to content

Onboarding: gitlab ci#4132

Merged
robertomonteromiguel merged 83 commits intomainfrom
robertomonteromiguel/onboarding_gitlab_ci
Mar 4, 2025
Merged

Onboarding: gitlab ci#4132
robertomonteromiguel merged 83 commits intomainfrom
robertomonteromiguel/onboarding_gitlab_ci

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review March 3, 2025 20:02
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner March 3, 2025 20:02
@robertomonteromiguel robertomonteromiguel merged commit 7992fb2 into main Mar 4, 2025
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/onboarding_gitlab_ci branch March 4, 2025 07:38
robertomonteromiguel added a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant