Skip to content

Rename LibraryVersion to ComponentVersion, and ComponentVersion.library to ComponentVersion.name#4378

Merged
cbeauchesne merged 9 commits into
mainfrom
cbeauchesne/library-name
Mar 25, 2025
Merged

Rename LibraryVersion to ComponentVersion, and ComponentVersion.library to ComponentVersion.name#4378
cbeauchesne merged 9 commits into
mainfrom
cbeauchesne/library-name

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Clear code

Changes

Object's name

LibraryVersion is an object that ship :

  • a component name
  • and its version

Though, it's not necessarily a library (aka a dd-trace repo). It can also be an agent, or anything else that have a version.

Having it named LibraryVersion is misleading, ComponentVersion is more generic.

Property name

ComponentVersion.library was a string shipping the component's name. For the same reason, it's not necessarily a library, and it's a name. So change to name.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne changed the title Rename Library version to ComponentVersion, and ComponentVersion.library to ComponentVersion.name Rename LibraryVersion to ComponentVersion, and ComponentVersion.library to ComponentVersion.name Mar 25, 2025
@cbeauchesne cbeauchesne marked this pull request as ready for review March 25, 2025 15:22
@cbeauchesne cbeauchesne requested review from a team and mabdinur as code owners March 25, 2025 15:22
@cbeauchesne cbeauchesne requested review from pawelchcki and removed request for a team March 25, 2025 15:22
@cbeauchesne cbeauchesne requested review from Kyle-Verhoog, jade-guiton-dd, jandro996 and manuel-alvarez-alvarez and removed request for a team March 25, 2025 15:22
@cbeauchesne cbeauchesne enabled auto-merge (squash) March 25, 2025 15:24
@cbeauchesne cbeauchesne merged commit 87b4808 into main Mar 25, 2025
@cbeauchesne cbeauchesne deleted the cbeauchesne/library-name branch March 25, 2025 16:56
mtoffl01 pushed a commit that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants