Skip to content

Fix appsec truncation object_depth test#4380

Merged
eliottness merged 1 commit into
mainfrom
eliottness/fix-truncation
Mar 25, 2025
Merged

Fix appsec truncation object_depth test#4380
eliottness merged 1 commit into
mainfrom
eliottness/fix-truncation

Conversation

@eliottness
Copy link
Copy Markdown
Contributor

@eliottness eliottness commented Mar 25, 2025

Motivation

Support for libraries that will actually try to check the actual depth of the object passed as parameter

Changes

Broaden assert statement of the object depth span metric

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness marked this pull request as ready for review March 25, 2025 13:06
@eliottness eliottness requested review from a team as code owners March 25, 2025 13:07
@eliottness eliottness enabled auto-merge (squash) March 25, 2025 15:45
@eliottness eliottness merged commit 063d614 into main Mar 25, 2025
@eliottness eliottness deleted the eliottness/fix-truncation branch March 25, 2025 16:02
mtoffl01 pushed a commit that referenced this pull request Apr 3, 2025
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants