Fix appsec truncation object_depth test#4380
Merged
Merged
Conversation
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
IlyasShabi
approved these changes
Mar 25, 2025
RomainMuller
approved these changes
Mar 25, 2025
mtoffl01
pushed a commit
that referenced
this pull request
Apr 3, 2025
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support for libraries that will actually try to check the actual depth of the object passed as parameter
Changes
Broaden assert statement of the object depth span metric
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present