Skip to content

Use ensure-ci-success for all-green gatekeeper#4573

Merged
cbeauchesne merged 10 commits intomainfrom
cbeauchesne/ensure-ci-success
May 5, 2025
Merged

Use ensure-ci-success for all-green gatekeeper#4573
cbeauchesne merged 10 commits intomainfrom
cbeauchesne/ensure-ci-success

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne changed the title Use ensure-ci-success for all-green gatekeeper [nodejs] Use ensure-ci-success for all-green gatekeeper May 2, 2025
@cbeauchesne cbeauchesne changed the title [nodejs] Use ensure-ci-success for all-green gatekeeper [php] Use ensure-ci-success for all-green gatekeeper May 2, 2025
@cbeauchesne cbeauchesne changed the title [php] Use ensure-ci-success for all-green gatekeeper Use ensure-ci-success for all-green gatekeeper May 2, 2025
@cbeauchesne cbeauchesne marked this pull request as ready for review May 5, 2025 08:30
@cbeauchesne cbeauchesne requested a review from a team as a code owner May 5, 2025 08:30
@cbeauchesne cbeauchesne merged commit 402a03d into main May 5, 2025
431 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/ensure-ci-success branch May 5, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant